MF-320 All module-config keywords should be underscore-prefixed #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlorianRappl
approved these changes
Nov 11, 2020
| validators?: Array<Function>; | ||
| _default: ConfigValue; | ||
| _description?: string; | ||
| _validators?: Array<Function>; |
There was a problem hiding this comment.
Could we be more specific here? Is this, e.g., Array<ConfigValidator> where type ConfigValidator = (config: any) => boolean or similar?
There was a problem hiding this comment.
Oh yeah, great idea!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the other big, breaking config change (alongside #27 ).
This PR is against #27 just for the clean diff. It's built on top of it. Once this PR is approved, I'll merge it into that branch. Then, once PRs are out against all the other modules to update their config schemas as will be necessary, we can merge #27 to master.
I think it would also be a moment to major-version esm-core. Unless we're still informally considering esm-core 0-versioned.