MF-366 Config elements should have type
#27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @FlorianRappl ! I just added one more commit, to enable Typescript validation for theses "types". |
brandones
force-pushed
the
config-types
branch
from
bbc994f to
54feee4
Compare
FlorianRappl
reviewed
Nov 7, 2020
This was referenced Nov 13, 2020
|
Made a few more small changes while updating the other modules: 623914b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.openmrs.org/browse/MF-366
This removes support for the
is****validators, replacing them withtypedeclarations in the schema.All modules' configs must be updated simultaneously because this will break everything. I will change this to a normal PR once PRs against all the other modules are ready.