Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed visible template tags from all theme registration pages #4273

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Removed visible template tags from all theme registration pages #4273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1b2cb8
#4272 removes django tags from registration pages.
ajrbyers Jun 11, 2024
0f00402
Remove whitespace.
ajrbyers Jun 11, 2024
cf6677a
#4272 update based on comments.
ajrbyers Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/templates/common/elements/password_rules.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<li>
{% blocktrans trimmed with password_length=request.press.password_length %}
Your password should be {{ password_length }} characters long.
{% endblocktrans %}</li>
{% if request.press.password_upper %}
<li>{% blocktrans trimmed %}
Your password should contain at least one upper case letter.
{% endblocktrans %}</li>
{% endif %}
{% if request.press.password_number %}
<li>{% blocktrans trimmed %}
Your password should contain at least one number.
{% endblocktrans %}</li>
{% endif %}
4 changes: 1 addition & 3 deletions src/themes/OLH/templates/core/accounts/register.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,7 @@ <h5>{% trans "Register for an account with" %} {{ request.press.name }}.</h5>

<p>{% trans "Password Rules" %}:</p>
<ul class="no-top-margin">
<li>{% blocktrans with password_length=request.press.password_length %}Your password should be {{ password_length }} characters long.{% endblocktrans %}</li>
{% if request.press.password_upper %}<li>{% blocktrans %}Your password should contain at least one upper case letter."{% endblocktrans %} %}</li>{% endif %}
{% if request.press.password_number %}<li>{% blocktrans %}Your password should contain at least one number." %}{% endblocktrans %}</li>{% endif %}
{% include "common/elements/password_rules.html" %}
</ul>
<p>{% blocktrans %}For more information read our <a href="#" data-open="password-modal">password guide</a>.{% endblocktrans %}</p>

Expand Down
4 changes: 1 addition & 3 deletions src/themes/clean/templates/core/accounts/register.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,7 @@
<h5>{% trans "Register for an account with" %} {{ request.press.name }}.</h5>
<p>{% trans "Password Rules" %}:</p>
<ul class="no-top-margin">
<li>{% blocktrans with password_length=request.press.password_length %}Your password should be {{ password_length }} characters long.{% endblocktrans %}</li>
{% if request.press.password_upper %}<li>{% blocktrans %}Your password should contain at least one upper case letter."{% endblocktrans %} %}</li>{% endif %}
{% if request.press.password_number %}<li>{% blocktrans %}Your password should contain at least one number." %}{% endblocktrans %}</li>{% endif %}
{% include "common/elements/password_rules.html" %}
</ul>
<p>{% blocktrans %}For more information read our <a href="#" data-toggle="modal" data-target="#passwordmodal">password guide</a>.{% endblocktrans %}</p>

Expand Down
12 changes: 6 additions & 6 deletions src/themes/material/templates/core/accounts/register.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,13 @@
{% endif %}
<p>{% trans "Password Rules" %}:</p>
<ul class="no-top-margin browser-default">
<li>{% blocktrans with password_length=request.press.password_length %}Your password should be {{ password_length }} characters long.{% endblocktrans %}</li>
{% if request.press.password_upper %}<li>{% blocktrans %}Your password should contain at least one upper case letter."{% endblocktrans %} %}</li>{% endif %}
{% if request.press.password_number %}<li>{% blocktrans %}Your password should contain at least one number." %}{% endblocktrans %}</li>{% endif %}
{% include "common/elements/password_rules.html" %}
</ul>
<p>{% blocktrans %}For more information read our
<a href="#passwordmodal" class="modal-trigger">password guide</a>
.{% endblocktrans %}</p>
<p>
{% blocktrans trimmed %}For more information read our
<a href="#" data-target="passwordmodal" class="modal-trigger">password
guide</a>.{% endblocktrans %}
</p>
<form method="POST">
{% include "elements/forms/errors.html" %}
{% csrf_token %}
Expand Down