Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed visible template tags from all theme registration pages #4273

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

ajrbyers
Copy link
Member

@ajrbyers ajrbyers commented Jun 11, 2024

Closes #4272

Screenshot 2024-06-11 at 14 13 02 Screenshot 2024-06-11 at 14 14 09 Screenshot 2024-06-11 at 14 15 21

@ajrbyers ajrbyers changed the base branch from master to release_1_5_x June 11, 2024 13:11
@ajrbyers ajrbyers added this to the v1.5.6 milestone Jun 11, 2024
@ajrbyers ajrbyers requested a review from joemull June 11, 2024 13:12
Copy link
Member

@joemull joemull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think using {% blocktrans trimmed %} and introducing some linebreaks would help a lot with readability here:

<li>{% blocktrans trimmed with password_length=request.press.password_length %}
  Your password should be {{ password_length }} characters long.
{% endblocktrans %}</li>
{% if request.press.password_upper %}
  <li>{% blocktrans trimmed %}
    Your password should contain at least one upper case letter.
  {% endblocktrans %}</li>
{% endif %}
{% if request.press.password_number %}
  <li>{% blocktrans trimmed %}
    Your password should contain at least one number.
  {% endblocktrans %}</li>
{% endif %}

Could we also just move these three blocks to one common template use include?

@joemull joemull assigned ajrbyers and unassigned joemull Jun 11, 2024
@ajrbyers ajrbyers requested a review from joemull June 11, 2024 15:39
@ajrbyers ajrbyers assigned joemull and unassigned ajrbyers and joemull Jun 11, 2024
@joemull joemull assigned StephDriver and unassigned joemull Jun 12, 2024
@joemull joemull requested review from StephDriver and mauromsl and removed request for StephDriver June 12, 2024 13:28
@joemull joemull assigned mauromsl and unassigned StephDriver Jun 12, 2024
@mauromsl mauromsl merged commit 224afa4 into release_1_5_x Jun 19, 2024
1 check failed
@mauromsl mauromsl deleted the 4272-bugfix branch June 19, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Django tags visible on the registration page
4 participants