Stops multiple galley image files with the same name from being loaded in the edit galley interface. #4032

ajrbyers · 2024-03-15T13:23:47Z

Closes #3979

…omsl

…omsl

…w use check_for_existing_images should be set to True (and is in Prod/Typesetting).

… galley.images

ajrbyers added 6 commits March 15, 2024 13:21

#3979 guard against multiple image files per galley image.

d3fbb91

#3979 when handling a galley image check for duplicate image names

ea0ac42

#3979 updated comment.

907c090

#3979 tweaked the format of this function after discussion with @maur…

50e5cc0

…omsl

#3979 added trailing comma.

c933d80

#3979 updated warning text as per suggestion.

0c67820

ajrbyers changed the base branch from master to b_1_5_1 March 15, 2024 13:24

ajrbyers added 2 commits March 15, 2024 15:04

#3979 default behaviour now overwrites the existing file. For workflo…

9af0109

…w use check_for_existing_images should be set to True (and is in Prod/Typesetting).

#3979 add return after overwrite

e7d8699

ajrbyers requested review from mauromsl and joemull March 15, 2024 15:48

ajrbyers changed the title ~~3979 cherrypick~~ Stops multiple galley image files with the same name from being loaded in the edit galley interface. Mar 15, 2024

mauromsl approved these changes Mar 15, 2024

View reviewed changes

#3979 as the file is replaced, we don't need to remove the image from…

7906438

… galley.images

joemull approved these changes Mar 15, 2024

View reviewed changes

joemull merged commit 646319b into b_1_5_1 Mar 15, 2024
1 check was pending

joemull deleted the 3979-cherrypick branch March 15, 2024 16:22

joemull mentioned this pull request Mar 15, 2024

Stops multiple galley image files with the same name from being loaded in the edit galley interface. #3981

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stops multiple galley image files with the same name from being loaded in the edit galley interface. #4032

Stops multiple galley image files with the same name from being loaded in the edit galley interface. #4032

ajrbyers commented Mar 15, 2024 •

edited by joemull

Loading

Stops multiple galley image files with the same name from being loaded in the edit galley interface. #4032

Stops multiple galley image files with the same name from being loaded in the edit galley interface. #4032

Conversation

ajrbyers commented Mar 15, 2024 • edited by joemull Loading

ajrbyers commented Mar 15, 2024 •

edited by joemull

Loading