Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple galley images with the same name results in an error #3979

Closed
3 tasks done
ajrbyers opened this issue Feb 20, 2024 · 0 comments
Closed
3 tasks done

Multiple galley images with the same name results in an error #3979

ajrbyers opened this issue Feb 20, 2024 · 0 comments
Assignees
@ajrbyers
Labels
bug Something's not working dev-ready This issue has been refined and is ready for development.

Comments

@ajrbyers
Copy link
Member

ajrbyers commented Feb 20, 2024 •
edited
Loading

Describe the bug
If an editor/typesetter/production manager uploads two images with the same name this results in the image is not displayed.

Janeway version
1.5.1-RC-5

Pontential Solutions

  • For legacy we should add a handle for this in the identifier_figure view
  • When an image is uploaded that already exists, warn the user and recommend they use the replace file option
  • If the replace file option isn't present on this interface, add it
@ajrbyers ajrbyers added the bug Something's not working label Feb 20, 2024
@ajrbyers ajrbyers self-assigned this Feb 20, 2024
@ajrbyers ajrbyers added the dev-ready This issue has been refined and is ready for development. label Feb 20, 2024
ajrbyers added a commit that referenced this issue Feb 20, 2024
@ajrbyers
#3979 guard against multiple image files per galley image.
1b126f6
ajrbyers added a commit that referenced this issue Feb 20, 2024
@ajrbyers
#3979 when handling a galley image check for duplicate image names
d8af8a6
@ajrbyers ajrbyers mentioned this issue Feb 20, 2024
Closed
ajrbyers added a commit that referenced this issue Feb 22, 2024
@ajrbyers
#3979 updated comment.
941ff75
ajrbyers added a commit to openlibhums/typesetting that referenced this issue Feb 22, 2024
@ajrbyers
openlibhums/janeway#3979 adds changes required to the typesetting plu…
0d2e8b8 
…gin for this update.
ajrbyers added a commit that referenced this issue Feb 28, 2024
@ajrbyers
#3979 tweaked the format of this function after discussion with @maur…
726dd48 
…omsl
@joemull joemull mentioned this issue Mar 4, 2024
Merged
ajrbyers added a commit that referenced this issue Mar 15, 2024
@ajrbyers
#3979 added trailing comma.
b948a8e
ajrbyers added a commit that referenced this issue Mar 15, 2024
@ajrbyers
#3979 updated warning text as per suggestion.
515411f
ajrbyers added a commit that referenced this issue Mar 15, 2024
@ajrbyers
#3979 guard against multiple image files per galley image.
d3fbb91
ajrbyers added a commit that referenced this issue Mar 15, 2024
@ajrbyers
#3979 when handling a galley image check for duplicate image names
ea0ac42
ajrbyers added a commit that referenced this issue Mar 15, 2024
@ajrbyers
#3979 updated comment.
907c090
ajrbyers added a commit that referenced this issue Mar 15, 2024
@ajrbyers
#3979 tweaked the format of this function after discussion with @maur…
50e5cc0 
…omsl
ajrbyers added a commit that referenced this issue Mar 15, 2024
@ajrbyers
#3979 added trailing comma.
c933d80
ajrbyers added a commit that referenced this issue Mar 15, 2024
@ajrbyers
#3979 updated warning text as per suggestion.
0c67820
ajrbyers added a commit that referenced this issue Mar 15, 2024
@ajrbyers
#3979 default behaviour now overwrites the existing file. For workflo…
9af0109 
…w use check_for_existing_images should be set to True (and is in Prod/Typesetting).
ajrbyers added a commit that referenced this issue Mar 15, 2024
@ajrbyers
#3979 add return after overwrite
e7d8699
ajrbyers added a commit that referenced this issue Mar 15, 2024
@ajrbyers
#3979 as the file is replaced, we don't need to remove the image from…
7906438 
… galley.images
@joemull joemull mentioned this issue Mar 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajrbyers ajrbyers

Labels
bug Something's not working dev-ready This issue has been refined and is ready for development.
Projects
None yet
Milestone
No milestone
1 participant
@ajrbyers