Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editors will be warned when they attempt to assign a task to a user whose account is not active. #3054

Merged
merged 11 commits into from
Sep 8, 2022
Merged

Editors will be warned when they attempt to assign a task to a user whose account is not active. #3054

merged 11 commits into from
Sep 8, 2022

Conversation

joemull
Copy link
Member

@joemull joemull commented Aug 2, 2022 •
edited by ajrbyers
Loading

Closes #2822

@joemull joemull requested review from mauromsl and ajrbyers and removed request for mauromsl August 3, 2022 11:45
@joemull joemull marked this pull request as ready for review August 3, 2022 11:45
@ajrbyers ajrbyers changed the title Help editors avoid sending assignments to inactive accounts Editors will be warned when they attempt to assign a task to a user who's accont is not active. Aug 16, 2022
@joemull joemull changed the title Editors will be warned when they attempt to assign a task to a user who's accont is not active. Editors will be warned when they attempt to assign a task to a user whose account is not active. Aug 30, 2022
@ajrbyers
Copy link
Member

ajrbyers commented Sep 6, 2022

@joemull if you're happy with the changes I made this can be merged once the conflicts are dealt with.

@joemull joemull mentioned this pull request Sep 7, 2022
Merged
joemull and others added 11 commits September 8, 2022 13:24
@joemull
Create alternative ConfirmableForm that only shows if there are poten…
30d533c 
…tial errors #2822
@joemull
#2822 Warn editor creating review assignments if reviewer is inactive
faf2c40
@joemull
#2822 Warn editor creating revision requests if author is inactive
47a1641
@joemull
#2822 Add warning exclamation point to modal
dc67518
@joemull
#2822 Add inactive account checker to base class
6fdc842
@joemull
#2822 Warn editor creating copyediting assignments if copyeditor is i…
bf2bf4c 
…nactive
@joemull
#2822 Standardize inactive account checks
d0ada98
@joemull
#2822 Warn editor creating copyediting review assignments if author a…
93b7af1 
…ccount is inactive
@joemull
#2822 Added comment about exception in implementation
3f1d8fd
@ajrbyers @joemull
#2822 adds reviewer to the ReviewAssignmentForm and makes the form mo…
a1cf863 
…re self contained.
@ajrbyers @joemull
#2822 added some tests to the form.
e1ea4fe
@joemull joemull force-pushed the 2822-inactive-recipient-warning branch from e248c5e to e1ea4fe Compare September 8, 2022 13:16
@joemull joemull merged commit a2fb32e into master Sep 8, 2022
@joemull joemull deleted the 2822-inactive-recipient-warning branch September 8, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajrbyers ajrbyers Awaiting requested review from ajrbyers

@mauromsl mauromsl Awaiting requested review from mauromsl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tell editors before sending task requests to unactivated email addresses
2 participants
@joemull @ajrbyers