Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give section editors access to list views #2982

Closed
wants to merge 138 commits into from
Closed

Give section editors access to list views #2982

wants to merge 138 commits into from

Conversation

joemull
Copy link
Member

@joemull joemull commented Jul 4, 2022 •
edited
Loading

Closes #2229.

I talked to three editors who had worked with section or guest editors, and the consensus was that they should be able to search submissions and view the workflow list pages for review and copyediting, but only the articles to which they are assigned should be visible.

@joemull joemull requested review from mauromsl and ajrbyers and removed request for mauromsl July 4, 2022 13:37
mauromsl and others added 24 commits July 5, 2022 20:42
@mauromsl
Update documentation for 1.4.2
aac9990
@mauromsl
#2963: Updates unit tests
473705e
@ajrbyers
Show article IDs to copyeditors
a938642
@joemull
#2859 Add Undo Article Rejection button on archive page
7b0b020
@joemull
#2313 Ignore development files when loading notify plugins
a415ef3
@joemull
#2313 Add testing helper for editor assignments
03efd55
@joemull
#2313 Fix bug that meant language or translation of setting wasn't re…
74cec70 
…cognized
@joemull
#2313 Fix bugs causing incorrect email subjects
f143ce1
@joemull
#2313 Add testing helper for revision requests
f7b8b9e
@joemull
#2313 Add testing helpers for Copyeditor and Copyedit Assignment
1d9d00e
@joemull
#2313 More tests; strengthen tests to fail if no setting
58219b7
@ajrbyers
#1170 added admin definition for SectionOrdering.
a5e4667
@ajrbyers
#1170 adds issue-article sorting.
9e84f60
@ajrbyers
#2320 the OLH theme will now display text when an article is not peer…
90c5ff0 
… reviewed.
@joemull
#2859 Add documentation for unreject button
518849e
@ajrbyers @mauromsl
#3004 swap .difference for .exclude in when searching for repo reviewers
29b5fdb
@ajrbyers @mauromsl
#3004 grab the pk values
a49fdd8
@ajrbyers @mauromsl
#3004 reset these files.
5b878d1
@ajrbyers @mauromsl
#3004 remove migration thats from another branch.
1d07567
@ajrbyers @mauromsl
#3004 moved limits
2be05b8
@ajrbyers
#2847 replace hard coded text with calculation of next stage.
95e3e84
@joemull
#2313 Add default for copyeditor accepting or declining task
4360d9c
@joemull
#2313 Add testing helpers for section editor and peer reviewer
b1f6f2a
@joemull
#2313 Fix four email subject bugs
84cacef
ajrbyers and others added 15 commits September 5, 2022 14:10
@ajrbyers
#2840 removed extra full stop.
e5a19ee
@joemull
#1170 Edits to new copy
17d3b52
@joemull
Merge pull request #2990 from BirkbeckCTP/copyeditor_id
2aa666a 
Copyeditors can now see the article ID on the list and detail pages.
@ajrbyers
#1170 added sort by first page.
95193e4
@ajrbyers
merge
140b7b5
@mauromsl @ajrbyers
#2680: Re-adds fix lost in f0ff0bf
d53c06e
@joemull @ajrbyers
#3051 Classify Accepted stage as part of Review workflow element
d47e778
@joemull @ajrbyers
#3051 One more change to put Accepted under Review element
20b7146
@joemull @ajrbyers
#3051 Add view just for raising workflow element completion event
18be0f5
@joemull @ajrbyers
#3051 Create modal for moving article to next workflow element
5081f54
@joemull @ajrbyers
#3051 Add controls on article review page for handling accepted articles
1a763c2
@joemull @ajrbyers
#3051 Redirect back to review if error happens on acceptance
1fc81d0
@joemull @ajrbyers
#3051 Fix security tests related to articles in review
4856286
@joemull @ajrbyers
#3051 Use POST method for move request and check current stage
fd54be5
@hardyoyo @ajrbyers
Make requested translation markup changes for reset_password and regi…
b7c5ff1 
…ster templates
ajrbyers
ajrbyers approved these changes Sep 5, 2022
View reviewed changes
@ajrbyers
Copy link
Member

ajrbyers commented Sep 5, 2022

This looks good, a few comments and a conflict to resolve.

@joemull
Copy link
Member Author

joemull commented Sep 6, 2022

After it was approved, this branch was corrupted with a rebase that did not do what we wanted. It is superseded by #3115

@joemull joemull closed this Sep 6, 2022
@joemull joemull deleted the 2229-section-editor-list-access branch September 6, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajrbyers ajrbyers ajrbyers approved these changes

@mauromsl mauromsl Awaiting requested review from mauromsl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search Submissions for Section Editors
6 participants
@joemull @ajrbyers @mauromsl @alainna @fingolfin @hardyoyo