Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Articles getting stuck in stage Accepted #3051

Closed
5 tasks done
joemull opened this issue Jul 29, 2022 · 0 comments · Fixed by #3060
Closed
5 tasks done

Articles getting stuck in stage Accepted #3051

joemull opened this issue Jul 29, 2022 · 0 comments · Fixed by #3060
Assignees
Labels
bug Something's not working
Milestone

Comments

@joemull
Copy link
Member

joemull commented Jul 29, 2022

Describe the bug
When an article is accepted, several events are triggered behind the scenes such as depositing the article with Crossref and moving the article to the next workflow element. If an error happens during these events, there are a few side effects that we'd like to avoid and help users recover from.

A server error is raised, rather than a custom message, so the user has to click Back to get to a page they can take any further actions. The article is also moved into the Accepted stage, which typically is only a pass-through stage on the way to Copyediting, so it isn't very well handled for articles that get stuck there. If the user clicks Back to the article page, there are no actions they can take:

Screenshot from 2022-07-29 13-46-48

Screenshot from 2022-07-29 13-47-33

If the user tries to find the article in Search Submissions, the link to View Article does not take them anywhere:

Screenshot from 2022-07-29 12-55-56

Screenshot from 2022-07-29 12-56-23

Articles with stage Accepted also don't appear in the Review list page:

Screenshot from 2022-07-29 13-41-51

Janeway version
1.4.2

Planned changes

We discussed this and want to make the following changes:

  • When acceptance events fail, redirect back to Review page
  • Include articles with Accepted stage in Review list page
  • Fix "View Article" button for Accepted stage on Search Submissions page
  • Replace "Make a Decision" button with "Move to Next Stage" on Review page
  • Create a modal for Review page that opens with info if article in Accepted stage
@joemull joemull added the bug Something's not working label Jul 29, 2022
@joemull joemull added this to the 1.4.3 milestone Jul 29, 2022
@joemull joemull added this to v1.4.3 Jul 29, 2022
@joemull joemull moved this to Todo in v1.4.3 Jul 29, 2022
@joemull joemull self-assigned this Aug 3, 2022
@joemull joemull moved this from Todo to In Progress in v1.4.3 Aug 3, 2022
@joemull joemull moved this from In Progress to PR Submitted in v1.4.3 Aug 4, 2022
joemull added a commit that referenced this issue Aug 8, 2022
Repository owner moved this from PR Submitted to Done in v1.4.3 Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something's not working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant