DOI Manager #2888
Merged
DOI Manager #2888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
May 30, 2022
Closed
…must be unique for the article's journal.
ajrbyers
requested changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch addresses #1470 and #2734 with a new class-based view for filtering articles into sets, registering DOIs for them in batches, and polling Crossref for status in batches.
It includes changes to the CrossrefDeposit model, including storing the deposit document on the model, and separating Identifier from CrossrefDeposit with the intermediary CrossrefStatus.
CrossrefStatus knows about all the deposits that included a given identifier, but it keeps track of the current status by reading Crossref's response to the latest deposit when the user polls for a new status.
Users can filter by pub date, registration status, primary issue, and journal (if at press level).
Errors are displayed using the messages framework, including if Crossref settings are missing.
For the first time, we have unit tests for validating Crossref deposits. This code also updates our Crossref schema version to 4.8.1.
Includes other selected unit tests and end-user documentation.
Where possible, work on the filters has been incorporated into core to be re-usable by other class-based views in the future.
Fixes #1470 and #2734.