Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate DOIs #2848

Closed
ajrbyers opened this issue Apr 20, 2022 · 1 comment · Fixed by #2896
Closed

Duplicate DOIs #2848

ajrbyers opened this issue Apr 20, 2022 · 1 comment · Fixed by #2896
Assignees
@ajrbyers @joemull
Labels
bug Something's not working

Comments

@ajrbyers
Copy link
Member

Describe the bug
It is currently possible to have two DOIs that are the same.

Janeway version
1.4.1

To Reproduce
Steps to reproduce the behavior:

  1. Add a DOI
  2. Add another the same

Expected behavior
We should check that the DOI is not a duplicate.
@ajrbyers ajrbyers added the bug Something's not working label Apr 20, 2022
@joemull
Copy link
Member

joemull commented Apr 20, 2022

Will try solving this with a unique_together constraint that checks identifier string along with with id_type.

@joemull joemull self-assigned this Apr 20, 2022
@joemull joemull added this to v1.4.2 Apr 20, 2022
@joemull joemull moved this to Todo in v1.4.2 Apr 20, 2022
@joemull joemull moved this from Todo to In Progress in v1.4.2 May 10, 2022
@joemull joemull moved this from In Progress to Todo in v1.4.2 May 30, 2022
@joemull joemull removed their assignment May 30, 2022
joemull added a commit that referenced this issue May 30, 2022
@joemull
#2848 Migration work in progress
aa5bca0
ajrbyers added a commit that referenced this issue May 31, 2022
@ajrbyers
#2848 DOIs must now be unique across all journals. Other identifiers …
3c8a24f 
…must be unique for the article's journal.
@ajrbyers ajrbyers mentioned this issue May 31, 2022
Merged
@ajrbyers ajrbyers moved this from Todo to PR Submitted in v1.4.2 May 31, 2022
ajrbyers added a commit that referenced this issue Jun 8, 2022
@ajrbyers
#2848 updated form, also added tests.
ca8b2d5
ajrbyers added a commit that referenced this issue Jun 8, 2022
@ajrbyers
#2848 addresses comments.
8c181a3
mauromsl pushed a commit that referenced this issue Jun 9, 2022
@joemull @mauromsl
#2848 Migration work in progress
b13f15e
mauromsl pushed a commit that referenced this issue Jun 9, 2022
@ajrbyers @mauromsl
#2848 DOIs must now be unique across all journals. Other identifiers …
e18cc45 
…must be unique for the article's journal.
mauromsl pushed a commit that referenced this issue Jun 9, 2022
@ajrbyers @mauromsl
#2848 updated form, also added tests.
200e346
mauromsl pushed a commit that referenced this issue Jun 9, 2022
@ajrbyers @mauromsl
#2848 addresses comments.
5eb2b15
joemull added a commit that referenced this issue Jun 14, 2022
@joemull
#2848 Address comments on migration
989f577
@joemull joemull linked a pull request Jun 14, 2022 that will close this issue
Deduplicate identifiers #2896
Merged
@joemull joemull moved this from PR Submitted to Done in v1.4.2 Jun 15, 2022
@joemull joemull closed this as completed Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajrbyers ajrbyers

@joemull joemull

Labels
bug Something's not working
Projects
No open projects
v1.4.2
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deduplicate identifiers openlibhums/janeway
2 participants
@ajrbyers @joemull