-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preprints author rework #2079
Merged
Merged
Preprints author rework #2079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@tingletech @hardyoyo here is a draft PR - can you take a look and let me know what you think? |
some bugs I found while testing I think are addressed by #2084 |
@tingletech if I remember correctly the only thing we need to finish here is getting the migration to work properly, correct? |
Yes, my recollection is that everything was working great apart from the
migration. :)
…On Mon, 9 Aug 2021, 17:55 Andy Byers, ***@***.***> wrote:
@tingletech <https://github.com/tingletech> if I remember correctly the
only thing we need to finish here is getting the migration to work
properly, correct?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2079 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADXIQB5AB2PZ36SJG4VDRN3T4BFEXANCNFSM4YVFXLZA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the
Preprint <> Preprint Author <> Author
model to:Preprint <> PreprintAuthor <> Account
It also fixes:
Closes #2070
Closes #2041
Closes #1973
Closes #1954