Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preprints author rework #2079

Merged
merged 17 commits into from
Aug 11, 2021
Merged

Preprints author rework #2079

merged 17 commits into from
Aug 11, 2021

Conversation

ajrbyers
Copy link
Member

@ajrbyers ajrbyers commented Mar 5, 2021

This PR reworks the Preprint <> Preprint Author <> Author model to: Preprint <> PreprintAuthor <> Account

It also fixes:

  • The subject list
  • Author deletion by Managers
  • Author reordering by Managers

Closes #2070
Closes #2041
Closes #1973
Closes #1954

@ajrbyers
Copy link
Member Author

ajrbyers commented Mar 8, 2021

@tingletech @hardyoyo here is a draft PR - can you take a look and let me know what you think?

@tingletech
Copy link
Contributor

some bugs I found while testing I think are addressed by #2084

@ajrbyers ajrbyers added this to the 1.4.2 milestone May 5, 2021
@ajrbyers ajrbyers marked this pull request as ready for review August 9, 2021 14:48
@ajrbyers
Copy link
Member Author

ajrbyers commented Aug 9, 2021

@tingletech if I remember correctly the only thing we need to finish here is getting the migration to work properly, correct?

@alainna
Copy link
Contributor

alainna commented Aug 10, 2021 via email

@ajrbyers ajrbyers changed the base branch from preprint-remodel to preprint-merge August 11, 2021 13:28
@ajrbyers ajrbyers merged commit c685336 into preprint-merge Aug 11, 2021
@ajrbyers ajrbyers deleted the preprints-author_rework branch August 11, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants