Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Preprints] Manager cannot add a registered author to a preprint #1954

Closed
alainna opened this issue Dec 15, 2020 · 3 comments
Closed

[Preprints] Manager cannot add a registered author to a preprint #1954

alainna opened this issue Dec 15, 2020 · 3 comments
Labels
bug Something's not working
Milestone

Comments

@alainna
Copy link
Contributor

alainna commented Dec 15, 2020

Describe the bug
When a manager edits a submitted or published preprint's metadata to add a co-author then clicks "Save Author" or "Save Metadata", the system will return an error and not add the co-author if the co-author's email address is already registered in the system.

Janeway version
janeway preprints

To Reproduce
Steps to reproduce the behavior:

  1. Navigate to preprint (ex: https://dev.eartharxiv.org/repository/manager/1720/ ) and click "Edit Metadata" under Controls: https://dev.eartharxiv.org/repository/manager/1720/edit/
  2. Add an author whose email address is already in the system (ex: [email protected] )
  3. Click "Save Author" and receive an error notice:

Form errors:
Email address
Author with this Email address already exists.

  1. Because author data still appears to be in the form, scroll down and click "Save Metadata"
  2. The new author's data is not in the preprint metadata: https://dev.eartharxiv.org/repository/manager/1720/

Expected behavior

  1. The new author's data is in the preprint metadata.
  2. There would be an option for the author / manager to search for existing authors by name or email address (similar to what is on the author's submission form): "Add an author already in the system"

Additional context
This does not occur when a submitter adds authors on the initial submission form

@alainna alainna added the bug Something's not working label Dec 15, 2020
@ajrbyers
Copy link
Member

Noooo! I fixed this already. Will take a look tomorrow.

@tingletech
Copy link
Contributor

seems like to fix this, we would need to have the "Add an author already in the system" from the author's submission form and change "➕More Author Forms" to "➕Add an author NOT already in the system"

Screen Shot 2021-02-11 at 7 14 58 AM

Screen Shot 2021-02-11 at 7 20 39 AM

@tingletech
Copy link
Contributor

tingletech commented Feb 11, 2021

or, if there is an email match, then 1) ignore all the other fields and 2) use the info already associated with the author, and change the message to "Author with this Email address already exists -- using data from the author's record"?

NOTE: This looks like the place where author re-ordering could happen?

@alainna alainna changed the title Manager cannot add a registered author to a preprint [Preprints] Manager cannot add a registered author to a preprint Feb 23, 2021
@ajrbyers ajrbyers added this to the 1.4.2 milestone May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something's not working
Projects
None yet
Development

No branches or pull requests

3 participants