re #1633: finish preprint->repository refactor for searching preprints #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hardyoyo
commented
Aug 10, 2020
hardyoyo
commented
- use correct object models throughout
- tweak search form to use a name for the search_term input
- tweak list page to indicate the search_term if it's present
…ng preprints - use correct object models throughout - tweak search form to use a name for the search_term input - tweak list page to indicate the search_term if it's present
hardyoyo
commented
Aug 10, 2020
src/repository/views.py
Outdated
| authors__in=from_author, | ||
| stage=submission_models.STAGE_PREPRINT_PUBLISHED, | ||
| date_published__lte=timezone.now())] | ||
| # preprints_from_author = [preprint for preprint in models.Preprint.objects.filter( |
There was a problem hiding this comment.
Oops... I forgot that I'd commented the author and institution search to get this working... that remains to be done.
There was a problem hiding this comment.
I think I'm in over my head with this... I can't seem to make progress on searching by author name or institution... we may want to defer that functionality for a future ticket?
|
I'll take a look the AM.
…On Mon, 10 Aug 2020, 23:48 Hardy Pottinger, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/repository/views.py
<#1763 (comment)>:
>
- articles_from_author = [article for article in submission_models.Article.preprints.filter(
- authors__in=from_author,
- stage=submission_models.STAGE_PREPRINT_PUBLISHED,
- date_published__lte=timezone.now())]
+ # preprints_from_author = [preprint for preprint in models.Preprint.objects.filter(
I think I'm in over my head with this... I can't seem to make progress on
searching by author name or institution... we may want to defer that
functionality for a future ticket?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1763 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB7PSYTZUF4ZLSJOH7XT6LTSAB2KHANCNFSM4P2GXRSA>
.
|
… results, yet, but doesn't error
…ll doesn't return matches on author names
…om_author filter, still doesn't work, but is more correct than pk, keeping it, also reworded a comment to make it more correct
|
superseded by #1766, closing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.