Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preprints - Fix search page #1633

Closed
ajrbyers opened this issue Jun 17, 2020 · 3 comments
Closed

Preprints - Fix search page #1633

ajrbyers opened this issue Jun 17, 2020 · 3 comments
Assignees
@hardyoyo
Labels
documentation Ideas for new or improved user documentation preprints
Milestone
Repository - MEMO...

Comments

@ajrbyers
Copy link
Member

ajrbyers commented Jun 17, 2020 •
edited
Loading

repository.views.preprints_search needs totally reimplemented including:

  1. Changing the url and view name
  2. Switching from submissiom_models.Article to models.Preprint
  3. Update the implementation so that title__icontains searches for instances of each sub string not the whole search term
@ajrbyers ajrbyers added documentation Ideas for new or improved user documentation preprints labels Jun 17, 2020
@ajrbyers ajrbyers added this to the Repository - MEMORY-ALPHA milestone Jul 13, 2020
@hardyoyo
Copy link
Contributor

This description needs filling out.

@ajrbyers
Copy link
Member Author

@hardyoyo added some info now.

@hardyoyo
Copy link
Contributor

I will tackle this, feel free to assign to me

hardyoyo added a commit to hardyoyo/janeway that referenced this issue Aug 10, 2020
@hardyoyo
re openlibhums#1633: finish preprint->repository refactor for searchi…
2e9031b 
…ng preprints

- use correct object models throughout
- tweak search form to use a name for the search_term input
- tweak list page to indicate the search_term if it's present
hardyoyo added a commit to hardyoyo/janeway that referenced this issue Aug 11, 2020
@hardyoyo
openlibhums#1633 WIP, attempt to search by author name, not returning…
ec53f8c 
… results, yet, but doesn't error
hardyoyo added a commit to hardyoyo/janeway that referenced this issue Aug 11, 2020
@hardyoyo
openlibhums#1633 WIP, add preprints_from_author to preprints set, sti…
b3ba08e 
…ll doesn't return matches on author names
hardyoyo added a commit to hardyoyo/janeway that referenced this issue Aug 11, 2020
@hardyoyo
openlibhums#1633 WIP, try using id instead of pk in the values for fr…
c065633 
…om_author filter, still doesn't work, but is more correct than pk, keeping it, also reworded a comment to make it more correct
ajrbyers added a commit that referenced this issue Aug 12, 2020
@ajrbyers
#1633 potential search solution.
73570ea
ajrbyers added a commit that referenced this issue Aug 13, 2020
@ajrbyers
#1633 changed affiliation query.
2c7a7c2
ajrbyers added a commit that referenced this issue Aug 13, 2020
@ajrbyers
#1633 potential search solution.
53adb41
ajrbyers added a commit that referenced this issue Aug 13, 2020
@ajrbyers
#1633 changed affiliation query.
6d62f95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hardyoyo hardyoyo

Labels
documentation Ideas for new or improved user documentation preprints
Projects
None yet
Milestone
Repository - MEMORY-ALPHA
Development

No branches or pull requests
2 participants
@hardyoyo @ajrbyers