Fix thing-type retrieval and add-on management #1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job #728: Bundle Size — 15.97MiB (-0.02%).Metrics (3 changes)
Total size by type (2 changes)
|
Signed-off-by: Jan N. Klug <[email protected]>
J-N-K
force-pushed
the
bug-thing-type-retrieval
branch
from
2188b51 to
7ca8b75
Compare
J-N-K
changed the title
kaikreuzer
approved these changes
Jan 21, 2023
ghys
approved these changes
Jan 22, 2023
There was a problem hiding this comment.
Okay, finally have a test 4.0 instance running to test.
LGTM, but there are still some regressions that would have to be handled:
- installing add-ons on a fresh instance using the setup wizard is still broken
- "featured" add-ons (i.e. those arbitrary selected to appearing as cards on top of store sections) need to be adjusted
- installed add-ons from the distribution have (short) descriptions now so it's what appears when going to their page (before pressing "more").
These are relatively minor so still merging as it fixes the general brokenness.
ghys
added a commit
to ghys/openhab-webui
that referenced
this pull request
Jan 22, 2023
Fix setup wizard, installed Karaf addon description, featured addons. See openhab#1651 (review) for details. Signed-off-by: Yannick Schaus <[email protected]>
ghys
added a commit
that referenced
this pull request
Jan 22, 2023
Fix setup wizard, installed Karaf addon description, featured addons. See #1651 (review) for details. Signed-off-by: Yannick Schaus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1468
Depends on openhab/openhab-core#3293
-Add-ons from community marketplace and JSON 3rd party add-on-service could not be installed
Signed-off-by: Jan N. Klug [email protected]