Adapt to core changes (addon.xml) #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
I didn't see an add-on for the iconset. Can it be installed separately? |
|
The iconset is always installed to prevent issues, see openhab/openhab-distro#1371. |
|
@J-N-K Is there a special reason, why this PR is still marked as "WIP" in the title? |
|
To be honest: I can't remember. I'll check tomorrow. After the core changes are approved I need a day or two to finalize the addons-PR since new addons were added since I created it. I just want to prevent double-work there in case something needs to be changed. |
J-N-K
changed the title
|
I fixed some minor issues, ready now from my side |
Job #697: Bundle Size — 15.97MiB (~+0.01%).Metrics (1 change)
Total size by type (2 changes)
|
|
Is the file |
|
No, I removed it. |
Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: Jan N. Klug <[email protected]>
This reverts commit f0ab4e42578131cffaed6f48941083a3b7891eaa. Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: Jan N. Klug <[email protected]>
kaikreuzer
force-pushed
the
feature-addon
branch
from
14444ba to
10922f3
Compare
kaikreuzer
approved these changes
Jan 15, 2023
crnjan
pushed a commit
to crnjan/openhab-webui
that referenced
this pull request
Jan 17, 2023
Signed-off-by: Jan N. Klug <[email protected]> Signed-off-by: Boris Krivonog <[email protected]>
wborn
added a commit
to wborn/openhab-webui
that referenced
this pull request
Aug 21, 2023
It is still using /bindings to get the data resulting in a 404 Not Found. The other pages were updated in openhab#1468. Signed-off-by: Wouter Born <[email protected]>
florian-h05
pushed a commit
that referenced
this pull request
Aug 29, 2023
It is still using /bindings to get the data resulting in a 404 Not Found. The other pages were updated in #1468. Signed-off-by: Wouter Born <[email protected]>
florian-h05
added a commit
that referenced
this pull request
Aug 30, 2023
It is still using /bindings to get the data resulting in a 404 Not Found. The other pages were updated in #1468. Signed-off-by: Wouter Born <[email protected]> (cherry-picked from commit 312aa0e)
stefan-hoehn
pushed a commit
to stefan-hoehn/openhab-webui
that referenced
this pull request
Sep 23, 2023
It is still using /bindings to get the data resulting in a 404 Not Found. The other pages were updated in openhab#1468. Signed-off-by: Wouter Born <[email protected]> Signed-off-by: Stefan Höhn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1452
Depends on openhab/openhab-core#3050