Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated logo for the Plex Media Player #2090

Merged
merged 2 commits into from
Jul 1, 2023
Merged

Conversation

aronbeurskens
Copy link
Contributor

PR #15057 Added support for the Plex Media Player. This updates the logo for the binding.

PR #15057 Added support for the Plex Media Player. This updates the logo for the binding.

Signed-off-by: Aron Beurskens <[email protected]>
@netlify
Copy link

netlify bot commented Jun 10, 2023

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Name Link
🔨 Latest commit 9abe86f
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/648466077cc2c0000884df14
😎 Deploy Preview https://deploy-preview-2090--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@fwolter
Copy link
Member

fwolter commented Jun 10, 2023

If I see correctly the logo is transparent with white letters. The logo will be displayed on a white background on the openHAB website.

@aronbeurskens
Copy link
Contributor Author

I see the problem. I found a dark one. Not 100% sure if it is the official logo, but it looks very alike.

Added dark plex logo to be visible on white background

Signed-off-by: Aron Beurskens <[email protected]>
Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

@stefan-hoehn stefan-hoehn added this to the 4.0 milestone Jul 1, 2023
@stefan-hoehn stefan-hoehn merged commit 8420a9a into openhab:main Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants