Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plex] Initial contribution #15057

Merged
merged 6 commits into from
Jun 10, 2023
Merged

[plex] Initial contribution #15057

merged 6 commits into from
Jun 10, 2023

Conversation

mlobstein
Copy link
Contributor

@mlobstein mlobstein commented Jun 7, 2023 •
edited
Loading

mlobstein added 2 commits June 7, 2023 17:08
@mlobstein
aronbeurskens plex baseline
eddf08e 
Signed-off-by: Michael Lobstein <[email protected]>
@mlobstein
review changes
c8c1618 
Signed-off-by: Michael Lobstein <[email protected]>
@mlobstein mlobstein added new binding If someone has started to work on a binding. For a new binding PR. oh1 migration Relates to migrating an openHAB 1 addon to openHAB 2 labels Jun 7, 2023
@mlobstein mlobstein requested review from fwolter and jlaur June 7, 2023 22:35
@mlobstein mlobstein requested a review from a team as a code owner June 7, 2023 22:35
mlobstein added 2 commits June 7, 2023 20:41
@mlobstein
Clean-up PlexApiConnector exception handling
6342518 
Signed-off-by: Michael Lobstein <[email protected]>
@mlobstein
Additional clean-up
1ad97c8 
Signed-off-by: Michael Lobstein <[email protected]>
fwolter
fwolter requested changes Jun 8, 2023
View reviewed changes
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping the Git history! That made the review a lot easier.

...b.binding.plex/src/main/java/org/openhab/binding/plex/internal/handler/PlexApiConnector.java Outdated
sslContextFactory.setEndpointIdentificationAlgorithm(null);
logger.debug("Connecting to WebSocket");
try {
wsClient = new WebSocketClient(sslContextFactory);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This constructor is deprecated. You could pass a HttpClient with the SslContextFactory set. See

openhab-addons/bundles/org.openhab.binding.boschshc/src/main/java/org/openhab/binding/boschshc/internal/discovery/BridgeDiscoveryParticipant.java

Line 75 in 214e31b

httpClient = httpClientFactory.createHttpClient(BINDING_ID, sslContextFactory);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the change to pass in the httpClientFactory, create the custom httpClient, start it, stop it, etc. Hopefully someone can test these changes. The attached jar was updated.

@mlobstein
review changes
5626552 
Signed-off-by: Michael Lobstein <[email protected]>
@mlobstein mlobstein added the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label Jun 8, 2023
fwolter
fwolter requested changes Jun 9, 2023
View reviewed changes
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aronbeurskens is there any chance you can give this a quick connection test?

@aronbeurskens
Copy link

@mlobstein @fwolter I did a quick test run with the provided JAR on OpenHab 4.0.0 with Java 17.
Seems to be working ok.

@mlobstein
review changes
96076a4 
Signed-off-by: Michael Lobstein <[email protected]>
@mlobstein mlobstein requested a review from fwolter June 9, 2023 21:18
fwolter
fwolter approved these changes Jun 10, 2023
View reviewed changes
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for finishing this!

Now, any of you could add the binding's logo to the openHAB website. See https://www.openhab.org/docs/developer/bindings/#add-your-binding-s-logo-to-the-openhab-website

@fwolter fwolter removed the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label Jun 10, 2023
@fwolter fwolter merged commit 44a78b9 into openhab:main Jun 10, 2023
@aronbeurskens
Copy link

Great news, nice to see it finally merged into main.
Here is the PR for the bindings logo:

openhab/openhab-docs#2090

@mlobstein mlobstein mentioned this pull request Jun 10, 2023
Closed
@mlobstein mlobstein deleted the plex branch June 10, 2023 12:07
@jlaur jlaur linked an issue Jun 10, 2023 that may be closed by this pull request
[plex] Add Plex Binding #4949
Closed
@mlobstein
Copy link
Contributor Author

@fwolter @jlaur
Should this be tagged as a 4.0 milestone?

@fwolter fwolter added this to the 4.0 milestone Jun 12, 2023
@fwolter
Copy link
Member

fwolter commented Jun 12, 2023

Yes, thanks for the reminder!

tb4jc pushed a commit to tb4jc/openhab-addons that referenced this pull request Jun 19, 2023
@mlobstein @tburri-alstom
[plex] Initial contribution (openhab#15057)
4e933ef 
* aronbeurskens plex baseline

Signed-off-by: Michael Lobstein <[email protected]>

* review changes

Signed-off-by: Michael Lobstein <[email protected]>

* Clean-up PlexApiConnector exception handling

Signed-off-by: Michael Lobstein <[email protected]>

* Additional clean-up

Signed-off-by: Michael Lobstein <[email protected]>

* review changes

Signed-off-by: Michael Lobstein <[email protected]>

* review changes

Signed-off-by: Michael Lobstein <[email protected]>

---------

Signed-off-by: Michael Lobstein <[email protected]>
Signed-off-by: Thomas Burri <[email protected]>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Aug 9, 2023
@mlobstein @matchews
[plex] Initial contribution (openhab#15057)
2147517 
* aronbeurskens plex baseline

Signed-off-by: Michael Lobstein <[email protected]>

* review changes

Signed-off-by: Michael Lobstein <[email protected]>

* Clean-up PlexApiConnector exception handling

Signed-off-by: Michael Lobstein <[email protected]>

* Additional clean-up

Signed-off-by: Michael Lobstein <[email protected]>

* review changes

Signed-off-by: Michael Lobstein <[email protected]>

* review changes

Signed-off-by: Michael Lobstein <[email protected]>

---------

Signed-off-by: Michael Lobstein <[email protected]>
Signed-off-by: Matt Myers <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Aug 12, 2023
@aronbeurskens
Updated logo for the Plex Media Player (openhab#2090)
8420a9a 
* Updated logo for the Plex Media Player

PR openhab#15057 Added support for the Plex Media Player. This updates the logo for the binding.

Signed-off-by: Aron Beurskens <[email protected]>

* Added dark plex logo

Added dark plex logo to be visible on white background

Signed-off-by: Aron Beurskens <[email protected]>

---------

Signed-off-by: Aron Beurskens <[email protected]>
@jlaur jlaur mentioned this pull request Jan 1, 2024
Merged
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@mlobstein @austvik
[plex] Initial contribution (openhab#15057)
0d26e29 
* aronbeurskens plex baseline

Signed-off-by: Michael Lobstein <[email protected]>

* review changes

Signed-off-by: Michael Lobstein <[email protected]>

* Clean-up PlexApiConnector exception handling

Signed-off-by: Michael Lobstein <[email protected]>

* Additional clean-up

Signed-off-by: Michael Lobstein <[email protected]>

* review changes

Signed-off-by: Michael Lobstein <[email protected]>

* review changes

Signed-off-by: Michael Lobstein <[email protected]>

---------

Signed-off-by: Michael Lobstein <[email protected]>
Signed-off-by: Jørgen Austvik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwolter fwolter fwolter approved these changes

@jlaur jlaur Awaiting requested review from jlaur

Assignees
No one assigned
Labels
new binding If someone has started to work on a binding. For a new binding PR. oh1 migration Relates to migrating an openHAB 1 addon to openHAB 2
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

[plex] Add Plex Binding
3 participants
@mlobstein @aronbeurskens @fwolter