Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[max] Revert of #8418 and move standard max tests to binding #8423

Merged
merged 2 commits into from
Sep 7, 2020
Merged

[max] Revert of #8418 and move standard max tests to binding #8423

merged 2 commits into from
Sep 7, 2020

Conversation

Hilbrand
Copy link
Member

@Hilbrand Hilbrand commented Sep 7, 2020

No description provided.

@Hilbrand
[max] Revert "remove dependency on org.apache.commons.net.util (openh…
a44db07 
…ab#8418)"

This reverts commit 6aa1793.
It breaks the build because test fails.

Signed-off-by: Hilbrand Bouwkamp <[email protected]>
@Hilbrand
[max] Moved standard unit test to binding itself.
8a6261d 
Signed-off-by: Hilbrand Bouwkamp <[email protected]>
@Hilbrand Hilbrand requested a review from marcelrv as a code owner September 7, 2020 13:13
@TravisBuddy
Copy link

Travis tests were successful

Hey @Hilbrand,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@marcelrv
Copy link
Contributor

marcelrv commented Sep 7, 2020

LGTM

I'll create a new PR which wont fail the test

@wborn wborn merged commit 64a66a2 into openhab:2.5.x Sep 7, 2020
@Hilbrand Hilbrand deleted the fix-max branch September 7, 2020 14:10
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Sep 12, 2020
@Hilbrand @CSchlipp
[max] Revert of openhab#8418 and move standard max tests to binding (o…
0a33088 
…penhab#8423)

This reverts commit 6aa1793.
It breaks the build because test fails.

Moved standard unit test to binding itself.

Signed-off-by: Hilbrand Bouwkamp <[email protected]>
@wborn wborn added this to the 2.5.9 milestone Sep 18, 2020
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@Hilbrand @markus7017
[max] Revert of openhab#8418 and move standard max tests to binding (o…
4d15c36 
…penhab#8423)

This reverts commit 6aa1793.
It breaks the build because test fails.

Moved standard unit test to binding itself.

Signed-off-by: Hilbrand Bouwkamp <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Oct 8, 2020
@Hilbrand @andrewfg
[max] Revert of openhab#8418 and move standard max tests to binding (o…
0d1b803 
…penhab#8423)

This reverts commit 6aa1793.
It breaks the build because test fails.

Moved standard unit test to binding itself.

Signed-off-by: Hilbrand Bouwkamp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelrv marcelrv marcelrv approved these changes

@wborn wborn wborn approved these changes

Assignees
No one assigned
Labels
critical
Projects
None yet
Milestone
2.5.9
Development

Successfully merging this pull request may close these issues.
4 participants
@Hilbrand @TravisBuddy @marcelrv @wborn