Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[max] remove dependency on org.apache.commons.net.util #8418

Merged
merged 1 commit into from
Sep 7, 2020
Merged

[max] remove dependency on org.apache.commons.net.util #8418

merged 1 commit into from
Sep 7, 2020

Conversation

marcelrv
Copy link
Contributor

@marcelrv marcelrv commented Sep 6, 2020 •
edited
Loading

Replace org.apache.commons.net.util.Base64 with java.util.Base64

eliminating several warning messages
[WARNING] org.openhab.binding.max.internal.command.MCommand.java:[23] The package org.apache.commons.net.utils should not be used.

Signed-off-by: Marcel Verpaalen [email protected]

@marcelrv
[max] remove dependency on org.apache.commons.net.util
87b11b0 
Replace org.apache.commons.net.util.Base64 with java.util.Base64

Signed-off-by: Marcel Verpaalen <[email protected]>
@TravisBuddy
Copy link

Travis tests have failed

Hey @marcelrv,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

Hilbrand
Hilbrand approved these changes Sep 7, 2020
View reviewed changes
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. travis fails on itests.

@TravisBuddy
Copy link

Travis tests have failed

Hey @marcelrv,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

@marcelrv
Copy link
Contributor Author

marcelrv commented Sep 7, 2020

@openhab/core-maintainers Do you know why all the tests in itest are failing with a strange Cannot find /error/ch.qos.log for each import used? Any suggestions how to resolve? (note, I did not see anything in this PR that causes this)

[ERROR] Error   : Cannot find /error/ch.qos.logback.classic;version=[1.2.3,1.2.4) Not found in [openHAB Add-ons :: Integration Tests :: MaxCube Binding Tests [org.openhab.binding.max,org.openhab.binding.max.tests r/w=false], bnd-cache [/home/travis/build/openhab/openhab-addons/itests/org.openhab.binding.max.tests/target/test/tmp/testing/itest/cnf/cache/4.3.0/bnd-cache r/w=false], org.openhab.core.bom.runtime-index [/home/travis/build/openhab/openhab-addons/itests/org.openhab.binding.max.tests/target/test/tmp/testing/itest/cnf/cache/4.3.0/org.openhab.core.bom.runtime-index r/w=false], org.openhab.core.bom.test-index [/home/travis/build/openhab/openhab-addons/itests/org.openhab.binding.max.tests/target/test/tmp/testing/itest/cnf/cache/4.3.0/org.openhab.core.bom.test-index r/w=false], org.openhab.core.bom.openhab-core-index [/home/travis/build/openhab/openhab-addons/itests/org.openhab.binding.max.tests/target/test/tmp/testing/itest/cnf/cache/4.3.0/org.openhab.core.bom.openhab-core-index r/w=false], self [/home/travis/build/openhab/openhab-addons/itests/org.openhab.binding.max.tests/target/test/tmp/testing/itest/cnf/cache/4.3.0/self r/w=false]]
[ERROR] Error   : Cannot find /error/ch.qos.logback.core;version=[1.2.3,1.2.4) Not found in [openHAB Add-ons :: Integration Tests :: MaxCube Binding Tests [org.openhab.binding.max,org.openhab.binding.max.tests r/w=false], bnd-cache [/home/travis/build/openhab/openhab-addons/itests/org.openhab.binding.max.tests/target/test/tmp/testing/itest/cnf/cache/4.3.0/bnd-cache r/w=false], org.openhab.core.bom.runtime-index [/home/travis/build/openhab/openhab-addons/itests/org.openhab.binding.max.tests/target/test/tmp/testing/itest/cnf/cache/4.3.0/org.openhab.core.bom.runtime-index r/w=false], org.openhab.core.bom.test-index [/home/travis/build/openhab/openhab-addons/itests/org.openhab.binding.max.tests/target/test/tmp/testing/itest/cnf/cache/4.3.0/org.openhab.core.bom.test-index r/w=false], org.openhab.core.bom.openhab-core-index [/home/travis/build/openhab/openhab-addons/itests/org.openhab.binding.max.tests/target/test/tmp/testing/itest/cnf/cache/4.3.0/org.openhab.core.bom.openhab-core-index r/w=false], self [/home/travis/build/openhab/openhab-addons/itests/org.openhab.binding.max.tests/target/test/tmp/testing/itest/cnf/cache/4.3.0/self r/w=false]]

@fwolter fwolter closed this Sep 7, 2020
@fwolter fwolter reopened this Sep 7, 2020
@Hilbrand
Copy link
Member

Hilbrand commented Sep 7, 2020

itests seem a bit unstable when run on individual bindings. It won't run for me locally either 😞 I guess we can merge this.

@wborn
Copy link
Member

wborn commented Sep 7, 2020

Travis fails because it does a partial build which doesn't build the bnd indices (the bom projects).
Jenkins always does a full build which is slower but more reliable.
So if the Jenkins PR build succeeds, PRs can be merged.

@wborn wborn merged commit 6aa1793 into openhab:2.5.x Sep 7, 2020
@cweitkamp
Copy link
Contributor

@marcelrv 👍 Great. One step forward. But I am afraid you missed the occurrences inside the tests themselves. E.g.

openhab-addons/itests/org.openhab.binding.max.tests/src/main/java/org/openhab/binding/max/internal/command/TCommandTest.java

Line 17 in 127f05d

import org.apache.commons.net.util.Base64;

May I ask you to have a second look?

@wborn
Copy link
Member

wborn commented Sep 7, 2020

It does seem these tests now fail. I had forgotten Jenkins skips tests when building. 🙁

Hilbrand added a commit to Hilbrand/openhab-addons that referenced this pull request Sep 7, 2020
@Hilbrand
[max] Revert "remove dependency on org.apache.commons.net.util (openh…
a44db07 
…ab#8418)"

This reverts commit 6aa1793.
It breaks the build because test fails.

Signed-off-by: Hilbrand Bouwkamp <[email protected]>
wborn pushed a commit that referenced this pull request Sep 7, 2020
@Hilbrand
[max] Revert of #8418 and move standard max tests to binding (#8423)
64a66a2 
This reverts commit 6aa1793.
It breaks the build because test fails.

Moved standard unit test to binding itself.

Signed-off-by: Hilbrand Bouwkamp <[email protected]>
@marcelrv marcelrv deleted the max-remove-org.apache.commons.net.util branch September 7, 2020 18:50
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Sep 12, 2020
@marcelrv @CSchlipp
[max] remove dependency on org.apache.commons.net.util (openhab#8418)
d041a9c 
Replace org.apache.commons.net.util.Base64 with java.util.Base64

Signed-off-by: Marcel Verpaalen <[email protected]>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Sep 12, 2020
@Hilbrand @CSchlipp
[max] Revert of openhab#8418 and move standard max tests to binding (o…
0a33088 
…penhab#8423)

This reverts commit 6aa1793.
It breaks the build because test fails.

Moved standard unit test to binding itself.

Signed-off-by: Hilbrand Bouwkamp <[email protected]>
@wborn wborn added this to the 2.5.9 milestone Sep 18, 2020
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@marcelrv @markus7017
[max] remove dependency on org.apache.commons.net.util (openhab#8418)
5c31d75 
Replace org.apache.commons.net.util.Base64 with java.util.Base64

Signed-off-by: Marcel Verpaalen <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@Hilbrand @markus7017
[max] Revert of openhab#8418 and move standard max tests to binding (o…
4d15c36 
…penhab#8423)

This reverts commit 6aa1793.
It breaks the build because test fails.

Moved standard unit test to binding itself.

Signed-off-by: Hilbrand Bouwkamp <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Oct 8, 2020
@marcelrv @andrewfg
[max] remove dependency on org.apache.commons.net.util (openhab#8418)
1dec0d0 
Replace org.apache.commons.net.util.Base64 with java.util.Base64

Signed-off-by: Marcel Verpaalen <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Oct 8, 2020
@Hilbrand @andrewfg
[max] Revert of openhab#8418 and move standard max tests to binding (o…
0d1b803 
…penhab#8423)

This reverts commit 6aa1793.
It breaks the build because test fails.

Moved standard unit test to binding itself.

Signed-off-by: Hilbrand Bouwkamp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hilbrand Hilbrand Hilbrand approved these changes

@wborn wborn wborn approved these changes

@cweitkamp cweitkamp Awaiting requested review from cweitkamp

@cpmeister cpmeister Awaiting requested review from cpmeister

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.9
Development

Successfully merging this pull request may close these issues.
6 participants
@marcelrv @TravisBuddy @Hilbrand @wborn @cweitkamp @fwolter