Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEATO] add option to clean house with map and no-go lines #8310

Merged
merged 1 commit into from
Aug 26, 2020
Merged

[NEATO] add option to clean house with map and no-go lines #8310

merged 1 commit into from
Aug 26, 2020

Conversation

Tukks
Copy link

@Tukks Tukks commented Aug 18, 2020

[NEATO] add option to clean house with map and no-go lines

Improvements to Add option Clean with map to binding neato to launch clean with no-go line activated.
I don't remove the old clean option because of legacy and I don't know if this code work on a Neato D5
Tested only on neato D7.

see issue for more info #5761

@Tukks Tukks requested a review from jjlauterbach as a code owner August 18, 2020 20:25
@Tukks Tukks changed the title add neato clean with map [NEATO] add option to clean house with map and no-go lines Aug 18, 2020
@Tukks Tukks changed the title [NEATO] add option to clean house with map and no-go lines [WIP][NEATO] add option to clean house with map and no-go lines Aug 18, 2020
@Tukks
Copy link
Author

Tukks commented Aug 18, 2020

Where I can share the jar file for testing? What host do you recommend?

@Tukks Tukks changed the title [WIP][NEATO] add option to clean house with map and no-go lines [NEATO] add option to clean house with map and no-go lines Aug 18, 2020
@HerzScheisse-zz
Copy link
Contributor

Hey @Tukks ,

many thanks for adding this option..

maybe the community forum is the best way to provide the jar for testing...

Eigther this thread https://community.openhab.org/t/neato-botvac-binding/50406
or start a new one...

I have a D5 and could help with testing...

fwolter
fwolter requested changes Aug 20, 2020
View reviewed changes
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please sign-off your changes? See https://www.openhab.org/docs/developer/contributing.html#sign-your-work

@jjlauterbach As the code owner, do you agree with the changes?

@fwolter fwolter added the enhancement An enhancement or new feature for an existing add-on label Aug 20, 2020
@jjlauterbach
Copy link
Contributor

LGTM

@Tukks
Copy link
Author

Tukks commented Aug 20, 2020

Thanks for the feedback, I will do every change requested Monday and I will put the jar file on the forum too.

@TravisBuddy
Copy link

Travis tests were successful

Hey @Tukks,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@Tukks
Copy link
Author

Tukks commented Aug 24, 2020

@fwolter I signed-off my change and resolved all the comment you made.
@HerzScheisse I Added the Jar file to the forum.

@Tukks
add neato clean with map
735fecd 
Signed-off-by: Giuseppe Lapenta <[email protected]>
@TravisBuddy
Copy link

Travis tests were successful

Hey @Tukks,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@HerzScheisse-zz
Copy link
Contributor

@Tukks Thanks for this PR...

I can confirm that it also works with the D5 Model...

@Hilbrand Hilbrand requested a review from fwolter August 26, 2020 14:38
@fwolter fwolter merged commit 764e97b into openhab:2.5.x Aug 26, 2020
@fwolter fwolter added this to the 2.5.9 milestone Aug 26, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Tukks @andrewfg
[neato] add neato clean with map (openhab#8310)
e2ae2fb 
Signed-off-by: Giuseppe Lapenta <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Tukks @andrewfg
[neato] add neato clean with map (openhab#8310)
c8c577b 
Signed-off-by: Giuseppe Lapenta <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Tukks @andrewfg
[neato] add neato clean with map (openhab#8310)
83e9ed7 
Signed-off-by: Giuseppe Lapenta <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Tukks @andrewfg
[neato] add neato clean with map (openhab#8310)
aaa3756 
Signed-off-by: Giuseppe Lapenta <[email protected]>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@Tukks @DaanMeijer
[neato] add neato clean with map (openhab#8310)
5ed0911 
Signed-off-by: Giuseppe Lapenta <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Sep 12, 2020
@Tukks @CSchlipp
[neato] add neato clean with map (openhab#8310)
09ca4be 
Signed-off-by: Giuseppe Lapenta <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@Tukks @markus7017
[neato] add neato clean with map (openhab#8310)
87a0902 
Signed-off-by: Giuseppe Lapenta <[email protected]>
@jjlauterbach jjlauterbach mentioned this pull request Jun 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjlauterbach jjlauterbach jjlauterbach approved these changes

@fwolter fwolter fwolter approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
2.5.9
Development

Successfully merging this pull request may close these issues.
5 participants
@Tukks @HerzScheisse-zz @jjlauterbach @TravisBuddy @fwolter