Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[neato] Add housecleaning with map (category 4) #5761

Closed
dharenkamp opened this issue Jun 24, 2019 · 5 comments
Closed

[neato] Add housecleaning with map (category 4) #5761

dharenkamp opened this issue Jun 24, 2019 · 5 comments
Labels
enhancement An enhancement or new feature for an existing add-on

Comments

@dharenkamp
Copy link

If i start the cleaning in the Neato app it uses the map that the robot has saved.
If i use the cleaning command in openhab it ignores the maps and therefore my no-go-lines.

I think it is because of using category 2 for cleaning command.
In the documentation of neato api there is also a category 4 which should work with the maps.
Perhaps it is possible to add a new Command for "CleanMap" or something like this.

In NeatoRobot.java in lines 141 and 142 are these lines:
request.addParam("mode", this.state.getCleaning().getModeValue());
request.addParam("category", "2");

And i think this is the point were category 4 should be used in a new command.

I´m using openhab2 on a raspian stretch with openhab and plugin version 2.5.0.M1.
My neato robot is a D7 Connected.

@wborn wborn added the enhancement An enhancement or new feature for an existing add-on label Jul 28, 2019
@wborn wborn changed the title [neato][feature] Add housecleaning with map (category 4) [neato] Add housecleaning with map (category 4) Jul 28, 2019
@dharenkamp
Copy link
Author

I´ve added the necessary changes by myself.
fork of addons is here

Searching for assistance to get it to production status (testing, code quality etc.)

@ArjenKorevaar
Copy link
Member

Hi @dharenkamp,

I just got my D7 Connected as well and would like to add the option to clean with a persistent map (ie. category=4). However, I noticed your fork is no longer available? Would you still like to work on this change and appreciate some help on the PR? Otherwise I might create my own fork and take it from there...

@Tukks
Copy link

Tukks commented Aug 18, 2020

I made a PR to clean with map activated

@kathagor
Copy link

kathagor commented Sep 9, 2020

cleaning with map ist working with the changes from Tukks,

but I found in issue:
cleaning ist now much slower, than started by the neato app. I Think it's because "cleaning with map" sets NavigationMode to "deep(3)" .

In NeatoRobot.java; Line161

else if ("cleanWithMap".equalsIgnoreCase(command)) {
            request.setCmd("startCleaning");
            request.addParam("category", MAP.getCategory());
            request.addParam("mode", TURBO.getMode());
            request.addParam("navigationMode", DEEP.getNavigationMode());

@jjlauterbach
Copy link
Contributor

This capability was added by #8310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

No branches or pull requests

6 participants