Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nibeheatpump] Added further registers for model F1245 #7896

Merged
merged 14 commits into from
Jun 12, 2020

Conversation

Yogi4301
Copy link

Added the following register for holiday settings for F1245:

47374 - Start temperature cooling
47375 - Start temperature Heating
47376 - Start temperature additive
47377 - Outdoor filter time
48043 - Holiday - Activated
48046 - Heat Offset Holiday
48047 - Hot water mode Holiday

Signed-off-by: Joerg Schottmueller [email protected]

@Yogi4301 Yogi4301 requested a review from paulianttila as a code owner June 11, 2020 08:16
@Yogi4301
Copy link
Author

Signed-off-by: Joerg Schottmueller [email protected]

@TravisBuddy
Copy link

Travis tests were successful

Hey @Yogi4301,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister
Copy link
Contributor

Manualy checked sign-off

@cpmeister cpmeister merged commit 59f37f9 into openhab:2.5.x Jun 12, 2020
@cpmeister cpmeister added the enhancement An enhancement or new feature for an existing add-on label Jun 12, 2020
@cpmeister cpmeister added this to the 2.5.6 milestone Jun 12, 2020
knikhilwiz pushed a commit to knikhilwiz/openhab2-addons that referenced this pull request Jul 12, 2020
* Update f1x45-channel-groups.xml
* Update f1x45-types.xml
* Update F1X45.java
* Update README.md
* Update f1x45-channel-groups.xml
* Update f1x45-types.xml
* Update f1x45-channel-groups.xml
* Update F1X45.java
* Update README.md
* Update f1x45-types.xml
* Update README.md

Signed-off-by: Joerg Schottmueller <[email protected]>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
* Update f1x45-channel-groups.xml
* Update f1x45-types.xml
* Update F1X45.java
* Update README.md
* Update f1x45-channel-groups.xml
* Update f1x45-types.xml
* Update f1x45-channel-groups.xml
* Update F1X45.java
* Update README.md
* Update f1x45-types.xml
* Update README.md

Signed-off-by: Joerg Schottmueller <[email protected]>
Signed-off-by: CSchlipp <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
* Update f1x45-channel-groups.xml
* Update f1x45-types.xml
* Update F1X45.java
* Update README.md
* Update f1x45-channel-groups.xml
* Update f1x45-types.xml
* Update f1x45-channel-groups.xml
* Update F1X45.java
* Update README.md
* Update f1x45-types.xml
* Update README.md

Signed-off-by: Joerg Schottmueller <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
* Update f1x45-channel-groups.xml
* Update f1x45-types.xml
* Update F1X45.java
* Update README.md
* Update f1x45-channel-groups.xml
* Update f1x45-types.xml
* Update f1x45-channel-groups.xml
* Update F1X45.java
* Update README.md
* Update f1x45-types.xml
* Update README.md

Signed-off-by: Joerg Schottmueller <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
* Update f1x45-channel-groups.xml
* Update f1x45-types.xml
* Update F1X45.java
* Update README.md
* Update f1x45-channel-groups.xml
* Update f1x45-types.xml
* Update f1x45-channel-groups.xml
* Update F1X45.java
* Update README.md
* Update f1x45-types.xml
* Update README.md

Signed-off-by: Joerg Schottmueller <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
* Update f1x45-channel-groups.xml
* Update f1x45-types.xml
* Update F1X45.java
* Update README.md
* Update f1x45-channel-groups.xml
* Update f1x45-types.xml
* Update f1x45-channel-groups.xml
* Update F1X45.java
* Update README.md
* Update f1x45-types.xml
* Update README.md

Signed-off-by: Joerg Schottmueller <[email protected]>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
* Update f1x45-channel-groups.xml
* Update f1x45-types.xml
* Update F1X45.java
* Update README.md
* Update f1x45-channel-groups.xml
* Update f1x45-types.xml
* Update f1x45-channel-groups.xml
* Update F1X45.java
* Update README.md
* Update f1x45-types.xml
* Update README.md

Signed-off-by: Joerg Schottmueller <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
* Update f1x45-channel-groups.xml
* Update f1x45-types.xml
* Update F1X45.java
* Update README.md
* Update f1x45-channel-groups.xml
* Update f1x45-types.xml
* Update f1x45-channel-groups.xml
* Update F1X45.java
* Update README.md
* Update f1x45-types.xml
* Update README.md

Signed-off-by: Joerg Schottmueller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants