[kostalinverter] Kostal Inverter Binding extended with Piko second generation. #7796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #5579 Signed-off-by: Pauli Anttila <[email protected]>
Signed-off-by: Rob Nielsen <[email protected]>
Signed-off-by: Dominik Schön <[email protected]>
Signed-off-by: Reto Schneider <[email protected]>
Signed-off-by: Joe Inkenbrandt <[email protected]>
* Fix errors and changes after importing add-ons in Eclipse * Add missing Eclipse project/classpath files * Fix null analysis errors showing in Eclipse * Remove ignored Eclipse .settings files * Fix Eclipse linuxinput project name With these changes there are no unstaged changes and only one error showing in FileTailer (#5442) after importing the add-ons in Eclipse. Signed-off-by: Wouter Born <[email protected]>
Adding several new devices. including: yeelink.light.color4 #7016 Mi Home PTX Wall Switches (090615.switch.xswitch03) #7000 Xiaomi Ceiling Lamp (yeelink.light.ceiling11) #6787 Additional sensors and information in zhimi.airpurifier.v7 #5760 fix formatting and channel correct Shutdowm typo Signed-off-by: Marcel Verpaalen <[email protected]>
…7129) * Refactor and unify BluetoothAdapter implementation logic Signed-off-by: Connor Petty <[email protected]>
* Added status code and error code channel * Fix documentation Signed-off-by: Peter Schraffl <[email protected]>
Uses the diamond operator where ever possible. Also fixes many tight coupling issues by using interfaces instead of actual implementations. Fix bug in XiaomiBridgeSocket.setupSocket Add instructions for formatter Signed-off-by: Wouter Born <[email protected]>
It throws the exception for example using: smarthome:voice say "washer is done. dryer is done." Signed-off-by: Wouter Born <[email protected]>
Signed-off-by: Jan N. Klug <[email protected]>
* Fix SAT findings: ModifierOrderCheck, NewlineAtEndOfFileCheck, SimplifyBooleanExpressions, UnusedImportsCheck Fixes the following findings: * ModifierOrderCheck * NewlineAtEndOfFileCheck * SimplifyBooleanExpressions * UnusedImportsCheck * Fix Java 8 build Signed-off-by: Wouter Born <[email protected]>
Signed-off-by: Mark Hilbush <[email protected]>
Signed-off-by: Connor Petty <[email protected]>
…finition (#7297) - Add missing representation property 'host' in in gateway definition Signed-off-by: Arne Seime <[email protected]>
* Fix SAT NoEmptyLineSeparatorCheck findings * Fix sloppy coding and fragile comment Signed-off-by: Wouter Born <[email protected]>
Signed-off-by: Stefan Schmidhammer <[email protected]>
) * enhanced logging (show byte array in addition to string) * mention the type of status that could not be understood * performance considerations for logging Signed-off-by: Nils Schnabel <[email protected]>
* Correctly name STARTTLS and a few small improvements Signed-off-by: Kai Kreuzer <[email protected]>
Signed-off-by: Krzysztof Goworek <[email protected]>
Signed-off-by: Laurent Garnier <[email protected]>
With the changes in #6967 the HueEmulationServiceOSGiTest always fails for me. The reason is that if the discoveryIps are not configured, it is no longer guaranteed it will use the primary IPv4 host address as fallback. In my case the iterator on the HashSet would return an IPv6 address as first address. By using a LinkedHashSet the order is preserved and it will again use the primary IPv4 host address as fallback. Signed-off-by: Wouter Born <[email protected]>
* First commit of v2 SagerCaster Binding Signed-off-by: Gaël L'hopital <[email protected]>
* [lgwebos] Ignore power off command when the TV is already off Signed-off-by: Laurent Garnier <[email protected]>
…#7302) * [lgwebos] Update the thing configuration only if the key is different Avoid concurrent edit of thing configuration/properties Signed-off-by: Laurent Garnier <[email protected]>
…ules (#7295) * Add support for Beep and LED on/off features to Dimmer Modules(2457D2), On/Off Modules(2635-222), and On/Off Outdoor Modules(2634-222) Signed-off-by: Tom Weichmann <[email protected]>
.isEmpty() and !.isEmpty() express the intent more clearly and are therefore preferred. Counting the number of elements can also be an expensive operation e.g. when using certain linked list implementations (ConcurrentSkipListSet). .isEmpty() can be used instead of ".size() == 0" and ".size() < 1" !.isEmpty() can be used instead of ".size() != 0", ".size() > 0" and ".size() >= 1" Signed-off-by: Wouter Born <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
* [nikohomecontrol] Small README updates. * Remove obsolete profiles list as these cannot be retrieved with hobby API. * Fix timezone property. * Removed acting on public messages as not available in hobby API. Signed-off-by: Mark Herwege <[email protected]>
Well.... it's not only that. You do need to rebase your branch first on master and than force push the changes back to GitHub before switching the pull request target. Otherwise you'll end up with the mess that has been created now, with thousands of diffs and requesting a review from almost every contributor.... But you can't rebase until 2.5.x has been merged in master because currently the bindings are not in master. So the best thing to do is nothing at the moment and wait until the master is back as the default branch and then update. Than you can push back here and everything will be fine again. |
|
Thank's for your advices, |
|
The master should be back next week after 2.5.9 is released (if all goes according to plans). In that case master will be marked as the default branch. |
|
Could you please re-create this PR against the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binding redesigned 20200519 by Örjan Backsell
Signed-off-by: Örjan Backsell [email protected]
Also-by: Christian Schneider <>
Also-by: René Stakemeier <>
Also-by: Christoph Weitkamp <>
This is the upgraded version of Kostal Inverter extended with functionality for the Inverter type of Second generation PIKO 10-20
[kostalinverter]
[WIP]