Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lgwebos] Fix initialize and dispose #7301

Merged
merged 1 commit into from
Apr 5, 2020
Merged

[lgwebos] Fix initialize and dispose #7301

merged 1 commit into from
Apr 5, 2020

Conversation

lolodomo
Copy link
Contributor

@lolodomo lolodomo commented Apr 5, 2020

Signed-off-by: Laurent Garnier [email protected]

@lolodomo lolodomo requested a review from sprehn as a code owner April 5, 2020 11:55
@TravisBuddy
Copy link

Travis tests were successful

Hey @lolodomo,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

cpmeister
cpmeister approved these changes Apr 5, 2020
View reviewed changes
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister cpmeister merged commit 669ec98 into openhab:2.5.x Apr 5, 2020
@cpmeister cpmeister added this to the 2.5.4 milestone Apr 5, 2020
@cpmeister cpmeister added the bug An unexpected problem or unintended behavior of an add-on label Apr 5, 2020
@lolodomo lolodomo deleted the lgwebos_init_dispose branch April 5, 2020 14:20
Hans-Reiner pushed a commit to Hans-Reiner/openhab2-addons that referenced this pull request Apr 11, 2020
@lolodomo @Hans-Reiner
[lgwebos] Fix initialize and dispose (openhab#7301)
a05a52d 
Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: Hans-Reiner Hoffmann <[email protected]>
yfre pushed a commit to yfre/openhab-addons that referenced this pull request Apr 27, 2020
@lolodomo
[lgwebos] Fix initialize and dispose (openhab#7301)
4062eea 
Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: Eugen Freiter <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request May 29, 2020
@lolodomo @markus7017
[lgwebos] Fix initialize and dispose (openhab#7301)
c6c50f7 
Signed-off-by: Laurent Garnier <[email protected]>
LoungeFlyZ pushed a commit to LoungeFlyZ/openhab2-addons that referenced this pull request Jun 8, 2020
@lolodomo @LoungeFlyZ
[lgwebos] Fix initialize and dispose (openhab#7301)
1fe7a24 
Signed-off-by: Laurent Garnier <[email protected]>
J-N-K pushed a commit to J-N-K/openhab-addons that referenced this pull request Jul 14, 2020
@lolodomo @J-N-K
[lgwebos] Fix initialize and dispose (openhab#7301)
b0e43d6 
Signed-off-by: Laurent Garnier <[email protected]>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
@lolodomo @CSchlipp
[lgwebos] Fix initialize and dispose (openhab#7301)
dfc749a 
Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: CSchlipp <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[lgwebos] Fix initialize and dispose (openhab#7301)
b5e576a 
Signed-off-by: Laurent Garnier <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[lgwebos] Fix initialize and dispose (openhab#7301)
bffe017 
Signed-off-by: Laurent Garnier <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[lgwebos] Fix initialize and dispose (openhab#7301)
1396a8d 
Signed-off-by: Laurent Garnier <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[lgwebos] Fix initialize and dispose (openhab#7301)
5ae6411 
Signed-off-by: Laurent Garnier <[email protected]>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@lolodomo @DaanMeijer
[lgwebos] Fix initialize and dispose (openhab#7301)
b2e6cd5 
Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@lolodomo @markus7017
[lgwebos] Fix initialize and dispose (openhab#7301)
7968bdb 
Signed-off-by: Laurent Garnier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpmeister cpmeister cpmeister approved these changes

@sprehn sprehn Awaiting requested review from sprehn sprehn is a code owner

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
2.5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@lolodomo @TravisBuddy @cpmeister