Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lgwebos] Fix initialize and dispose #7301

Merged
merged 1 commit into from
Apr 5, 2020
Merged

[lgwebos] Fix initialize and dispose #7301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...ng.lgwebos/src/main/java/org/openhab/binding/lgwebos/internal/handler/LGWebOSHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ private LGWebOSConfiguration getLGWebOSConfig() {

@Override
public void initialize() {
logger.debug("Initializing handler for thing {}", getThing().getUID());
LGWebOSConfiguration c = getLGWebOSConfig();
logger.trace("Handler initialized with config {}", c);
String host = c.getHost();
Expand All @@ -135,11 +136,14 @@ public void initialize() {
s.setListener(this);
socket = s;

updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.NONE, "TV is off");

startReconnectJob();
}

@Override
public void dispose() {
logger.debug("Disposing handler for thing {}", getThing().getUID());
stopKeepAliveJob();
stopReconnectJob();

Expand All @@ -149,6 +153,7 @@ public void dispose() {
scheduler.execute(() -> s.disconnect()); // dispose should be none-blocking
}
socket = null;
config = null; // ensure config gets actually refreshed during re-initialization
super.dispose();
}

Expand Down