[teleinfo] Initial contribution

[olivierkeke]

Related to #680 issue (titled "Add Teleinfo Binding") and Community thread: https://community.openhab.org/t/new-teleinfo-binding-tester-and-feedback-welcome/77857

Clean rebase of #7516

[TravisBuddy]

Travis tests were successful

Hey @olivierkeke,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[TravisBuddy]

Travis tests were successful

Hey @olivierkeke,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[TravisBuddy]

Travis tests were successful

Hey @olivierkeke,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[TravisBuddy]

Travis tests were successful

Hey @olivierkeke,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[TravisBuddy]

Travis tests have failed

Hey @olivierkeke,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

[fwolter]

Seems like you managed to fix the mixed-up sign offs. @nokyyz If everything is fine, can you close your PR #7516? I will then review this PR.

[TravisBuddy]

Travis tests were successful

Hey @olivierkeke,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[nokyyz]

Seems like you managed to fix the mixed-up sign offs. @nokyyz If everything is fine, can you close your PR #7516? I will then review this PR.

Hi @fwolter, everything is fine for me. I have closed my PR #7516. Thx

[fwolter]

I saw that you put a lot of effort into this binding and you have my full respect to handle this complex protocol. I also like that you attached an UML diagram for documentation.

Here are some general points I found in the review:

There are several methods which log on entry and on exit. You could use the debugger for that purpose. See point 4 https://www.openhab.org/docs/developer/guidelines.html#f-logging

There are several checkstyle and compiler warnings left. You could take a look at target/code-analysis/report.html.

There are some formatting issues. You can view them with mvn spotless:check -Dspotless.check.skip=false and fix them with mvn spotless:apply.

Please use null annotations. See https://www.openhab.org/docs/developer/guidelines.html#null-annotations The data classes can be moved into a package called dto to prevent the missing null annotations.

[TravisBuddy]

Travis tests were successful

Hey @olivierkeke,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[TravisBuddy]

Travis tests were successful

Hey @olivierkeke,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[TravisBuddy]

Travis tests were successful

Hey @olivierkeke,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[TravisBuddy]

Travis tests were successful

Hey @olivierkeke,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[TravisBuddy]

Travis tests were successful

Hey @olivierkeke,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[TravisBuddy]

Travis tests were successful

Hey @olivierkeke,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[TravisBuddy]

Travis tests have failed

Hey @olivierkeke,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

[TravisBuddy]

Travis tests were successful

Hey @olivierkeke,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[TravisBuddy]

Travis tests were successful

Hey @olivierkeke,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[TravisBuddy]

Travis tests were successful

Hey @olivierkeke,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[TravisBuddy]

Travis tests were successful

Hey @olivierkeke,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[TravisBuddy]

Travis tests were successful

Hey @olivierkeke,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[TravisBuddy]

Travis tests were successful

Hey @olivierkeke,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[TravisBuddy]

Travis tests have failed

Hey @olivierkeke,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

[TravisBuddy]

Travis tests have failed

Hey @olivierkeke,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

[TravisBuddy]

Travis tests were successful

Hey @olivierkeke,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[TravisBuddy]

Travis tests were successful

Hey @olivierkeke,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[TravisBuddy]

Travis tests were successful

Hey @olivierkeke,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[TravisBuddy]

Travis tests were successful

Hey @olivierkeke,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[TravisBuddy]

Travis tests were successful

Hey @olivierkeke,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[olivierkeke]

@Hilbrand Thank you for the review. I think I've made the requested changes.

[TravisBuddy]

Travis tests were successful

Hey @olivierkeke,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[Hilbrand]

Just one issue left related to the change of using ThingHandlerService.

[TravisBuddy]

Travis tests were successful

Hey @olivierkeke,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[olivierkeke]

@Hilbrand Done!

[Hilbrand]

LGTM

[nokyyz]

Great ! Many thanks for all !