Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[teleinfo] Initial contribution #7516

Closed
wants to merge 146 commits into from
Closed

[teleinfo] Initial contribution #7516

wants to merge 146 commits into from

Conversation

nokyyz
Copy link

@nokyyz nokyyz commented May 1, 2020

Related to #680 issue (titled "Add Teleinfo Binding") and Community thread: https://community.openhab.org/t/new-teleinfo-binding-tester-and-feedback-welcome/77857

nokyyz added 30 commits July 11, 2019 23:31
@nokyyz
Initial commit
d33a703
@nokyyz
Initial commit of Teleinfo binding
b039717
@nokyyz
Merge branch 'master' of https://github.com/nokyyz/openhab2-addons.git
80ee107
@nokyyz
Add ADPS, HHPHC & lastUpdate channels to HC/HP electricity meter
dd861d2
@nokyyz
Disable Unused pricing configuration for HC/HP eletricity meter
65ec188
@nokyyz
Review of TeleinfoInputStream class
5214f26
@nokyyz
Add BASE electricity meter support
e56cbc7
@nokyyz
Merge branch 'master' of https://github.com/openhab/openhab2-addons
1d64751
@nokyyz
Add UML datamodel
992e4cf
@nokyyz
Total refactoring to support Base/HC/Ejp/Tempo CBEMM and
2cb9092 
Base/HC/Ejp/Tempo CBETM teleinfo frames
@nokyyz
Add unit test for CBETM EJP option
17573a2
@nokyyz
Add unit test for CBEMM Tempo option
7cb9a41
@nokyyz
Add ProgrammeCircuit1 and ProgrammeCircuit2 channels to Tempo option
aceaeb3
@nokyyz
Fix ThingUID constants with OpenHAB XML definitions
c3c17fe
@nokyyz
Update <label> of thing types
78354ce
@nokyyz
Add Retry mechanism on fatal errors
d71cb85
@nokyyz
Update "Retry in progress..." message (log)
a6ada0d
@nokyyz
Improve "Got invalid frame" error message and "The group line seems
9b57888 
corrupted"
@nokyyz
Improve "The label '%s' is unknown" error message
0a66593
@nokyyz
Fix https://github.com/nokyyz/openhab2-addons/issues/10 issue
173fadb
@nokyyz
Update info log "Serial port is initialized" to "Teleinfo Serial port is
c95645f 
initialized"
@nokyyz
Message logs improvements
ae1359f
@nokyyz
Fix typo issues
8001f6c
@nokyyz
Fix https://github.com/nokyyz/openhab2-addons/issues/7 issue
043cd6e
@nokyyz
Fix issues from OH code analysis report
33092af
@nokyyz
Message logs improvements
af06034
@nokyyz
Modify some message logs
76d8753
@nokyyz
Modifiy some message logs
b70406b
@nokyyz
Add current owner information in PortInUseException message log
44b8f17
@nokyyz
Fix https://github.com/nokyyz/openhab2-addons/issues/11 issue
5bf00cd
@nokyyz
Copy link
Author

nokyyz commented May 1, 2020

strange... 7208 files changed... something wrong !

@cpmeister cpmeister changed the base branch from master to 2.5.x May 1, 2020 22:34
@cpmeister
Copy link
Contributor

All new bindings should be merged against the 2.5.x branch unless they intend to only be available in openHAB 3.
Try rebasing against the latest 2.5.x branch and see if it resolves your conflicts.

@cpmeister cpmeister added the new binding If someone has started to work on a binding. For a new binding PR. label May 2, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @nokyyz,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

@nokyyz
Copy link
Author

nokyyz commented May 2, 2020

After the update of the artifact version from (teleinfo) pom.xml file (commit 9ff28be), my local build is sucessfully:
[INFO] openHAB Add-ons :: Bundles :: Teleinfo Binding ..... SUCCESS [ 31.378 s]

I don't know why Travis CI has failed...

nokyyz added 2 commits May 2, 2020 21:10
@nokyyz
Fix Code Analysis Tool error in serialController.xml file (whitespace
2d8a337 
characters used for indentation)
@nokyyz
Fix Code Analysis Tool error in TeleinfoInputStream.java file ("Count of
739efaf 
placeholder(0) is not equal to count of parameter(1)")

Signed-off-by: Nicolas SIBERIL <[email protected]>
@TravisBuddy
Copy link

Travis tests were successful

Hey @nokyyz,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@olivierkeke olivierkeke mentioned this pull request May 22, 2020
Merged
@olivierkeke olivierkeke mentioned this pull request Jun 3, 2020
Closed
@nokyyz
Copy link
Author

nokyyz commented Jun 10, 2020

The PR #7744 fix the issue of sign offs. This PR is cancelled

@nokyyz nokyyz closed this Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3cky 3cky Awaiting requested review from 3cky

@BobRak BobRak Awaiting requested review from BobRak

@caffineehacker caffineehacker Awaiting requested review from caffineehacker

@cdjackson cdjackson Awaiting requested review from cdjackson

@Cossey Cossey Awaiting requested review from Cossey

@cschneider cschneider Awaiting requested review from cschneider

@cweitkamp cweitkamp Awaiting requested review from cweitkamp

@davidgraeff davidgraeff Awaiting requested review from davidgraeff

@digitaldan digitaldan Awaiting requested review from digitaldan

@dominicdesu dominicdesu Awaiting requested review from dominicdesu

@fa2k fa2k Awaiting requested review from fa2k

@FlorianSW FlorianSW Awaiting requested review from FlorianSW

@fruggy83 fruggy83 Awaiting requested review from fruggy83

@gbicskei gbicskei Awaiting requested review from gbicskei

@gedejong gedejong Awaiting requested review from gedejong

@gerrieg gerrieg Awaiting requested review from gerrieg

@Hilbrand Hilbrand Awaiting requested review from Hilbrand

@J-N-K J-N-K Awaiting requested review from J-N-K

@jwveldhuis jwveldhuis Awaiting requested review from jwveldhuis

@kabili207 kabili207 Awaiting requested review from kabili207

@kaikreuzer kaikreuzer Awaiting requested review from kaikreuzer

@kgoderis kgoderis Awaiting requested review from kgoderis

@klocsson klocsson Awaiting requested review from klocsson

@kubawolanin kubawolanin Awaiting requested review from kubawolanin

@limdul79 limdul79 Awaiting requested review from limdul79

@lolodomo lolodomo Awaiting requested review from lolodomo

@Markinus Markinus Awaiting requested review from Markinus

@marvkis marvkis Awaiting requested review from marvkis

@mgeramb mgeramb Awaiting requested review from mgeramb

@mhilbush mhilbush Awaiting requested review from mhilbush

@MikeJMajor MikeJMajor Awaiting requested review from MikeJMajor

@Nebula83 Nebula83 Awaiting requested review from Nebula83

@ollie-dev ollie-dev Awaiting requested review from ollie-dev

@pail23 pail23 Awaiting requested review from pail23

@paphko paphko Awaiting requested review from paphko

@paulianttila paulianttila Awaiting requested review from paulianttila

@peuter peuter Awaiting requested review from peuter

@ppieczul ppieczul Awaiting requested review from ppieczul

@psmedley psmedley Awaiting requested review from psmedley

@rmichalak rmichalak Awaiting requested review from rmichalak

@RSStephens RSStephens Awaiting requested review from RSStephens

@sjsf sjsf Awaiting requested review from sjsf

@sprehn sprehn Awaiting requested review from sprehn

@ssalonen ssalonen Awaiting requested review from ssalonen

@svilenvul svilenvul Awaiting requested review from svilenvul

@syphr42 syphr42 Awaiting requested review from syphr42

@t-8ch t-8ch Awaiting requested review from t-8ch

@tavalin tavalin Awaiting requested review from tavalin

@tmrobert8 tmrobert8 Awaiting requested review from tmrobert8

@tratho tratho Awaiting requested review from tratho

@trokohl trokohl Awaiting requested review from trokohl

@vbier vbier Awaiting requested review from vbier

@wborn wborn Awaiting requested review from wborn

@Wire82 Wire82 Awaiting requested review from Wire82

Assignees
No one assigned
Labels
new binding If someone has started to work on a binding. For a new binding PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.