[daikin] Add Energy, compressor frequency and special mode channels #7708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#6980: Add compressor frequency channel #6115: Add energy current year channels Signed-off-by: Lukas Agethen <[email protected]>
cpmeister
requested changes
May 21, 2020
bundles/org.openhab.binding.daikin/src/main/resources/ESH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.daikin/src/main/resources/ESH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.daikin/src/main/resources/ESH-INF/thing/thing-types.xml
Show resolved
Hide resolved
...ding.daikin/src/main/java/org/openhab/binding/daikin/internal/handler/DaikinBaseHandler.java
Outdated
Show resolved
Hide resolved
...ng.daikin/src/main/java/org/openhab/binding/daikin/internal/handler/DaikinAcUnitHandler.java
Outdated
Show resolved
Hide resolved
...openhab.binding.daikin/src/main/java/org/openhab/binding/daikin/internal/api/InfoParser.java
Outdated
Show resolved
Hide resolved
...openhab.binding.daikin/src/main/java/org/openhab/binding/daikin/internal/api/InfoParser.java
Outdated
Show resolved
Hide resolved
.../org.openhab.binding.daikin/src/main/java/org/openhab/binding/daikin/internal/api/Enums.java
Show resolved
Hide resolved
...src/main/java/org/openhab/binding/daikin/internal/DaikinCommunicationForbiddenException.java
Outdated
Show resolved
Hide resolved
...ng.daikin/src/main/java/org/openhab/binding/daikin/internal/handler/DaikinAcUnitHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lukas Agethen <[email protected]>
Travis tests were successfulHey @LukasA83, |
Signed-off-by: Lukas Agethen <[email protected]>
Travis tests were successfulHey @LukasA83, |
|
Thanks for your feedback @cpmeister. I incorporated the changes as suggested, without the channel groups. |
cpmeister
added
the
enhancement
|
Quick question, @cpmeister : it is my first pull request therefore I'm not fully familiar with the review process... Is there any other action needed on my side or is it just about "approving" on your side? |
|
There isn't any action required from you at the moment, I'm just reaching out to other maintainers to get clarification on the channel group issue. I'll let you know what they tell me. If the documentation is correct then there is nothing else you need to do and I will approve this. |
|
Yep, documentation is correct. You are good to go then. |
cpmeister
approved these changes
May 23, 2020
LoungeFlyZ
pushed a commit
to LoungeFlyZ/openhab2-addons
that referenced
this pull request
Jun 8, 2020
…penhab#7708) * [daikin] Add Energy, compressor frequency and special mode channels openhab#6980: Add compressor frequency channel openhab#6115: Add energy current year channels * Update small typos and code refactoring as suggested by cpmeister * Update small typos and added units where possible Signed-off-by: Lukas Agethen <[email protected]>
J-N-K
pushed a commit
to J-N-K/openhab-addons
that referenced
this pull request
Jul 14, 2020
…penhab#7708) * [daikin] Add Energy, compressor frequency and special mode channels openhab#6980: Add compressor frequency channel openhab#6115: Add energy current year channels * Update small typos and code refactoring as suggested by cpmeister * Update small typos and added units where possible Signed-off-by: Lukas Agethen <[email protected]>
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Jul 26, 2020
…penhab#7708) * [daikin] Add Energy, compressor frequency and special mode channels openhab#6980: Add compressor frequency channel openhab#6115: Add energy current year channels * Update small typos and code refactoring as suggested by cpmeister * Update small typos and added units where possible Signed-off-by: Lukas Agethen <[email protected]> Signed-off-by: CSchlipp <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
…penhab#7708) * [daikin] Add Energy, compressor frequency and special mode channels openhab#6980: Add compressor frequency channel openhab#6115: Add energy current year channels * Update small typos and code refactoring as suggested by cpmeister * Update small typos and added units where possible Signed-off-by: Lukas Agethen <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
…penhab#7708) * [daikin] Add Energy, compressor frequency and special mode channels openhab#6980: Add compressor frequency channel openhab#6115: Add energy current year channels * Update small typos and code refactoring as suggested by cpmeister * Update small typos and added units where possible Signed-off-by: Lukas Agethen <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
…penhab#7708) * [daikin] Add Energy, compressor frequency and special mode channels openhab#6980: Add compressor frequency channel openhab#6115: Add energy current year channels * Update small typos and code refactoring as suggested by cpmeister * Update small typos and added units where possible Signed-off-by: Lukas Agethen <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
…penhab#7708) * [daikin] Add Energy, compressor frequency and special mode channels openhab#6980: Add compressor frequency channel openhab#6115: Add energy current year channels * Update small typos and code refactoring as suggested by cpmeister * Update small typos and added units where possible Signed-off-by: Lukas Agethen <[email protected]>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
…penhab#7708) * [daikin] Add Energy, compressor frequency and special mode channels openhab#6980: Add compressor frequency channel openhab#6115: Add energy current year channels * Update small typos and code refactoring as suggested by cpmeister * Update small typos and added units where possible Signed-off-by: Lukas Agethen <[email protected]> Signed-off-by: Daan Meijer <[email protected]>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
…penhab#7708) * [daikin] Add Energy, compressor frequency and special mode channels openhab#6980: Add compressor frequency channel openhab#6115: Add energy current year channels * Update small typos and code refactoring as suggested by cpmeister * Update small typos and added units where possible Signed-off-by: Lukas Agethen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6980: Add compressor frequency channel
#6115: Add energy current year channels
Add special modes - Powerful channel
Signed-off-by: Lukas Agethen [email protected]