[daikin][wip] add energy readings #7471
Conversation
Signed-off-by: Wouter Denayer <[email protected]>
Signed-off-by: Wouter Denayer <[email protected]>
Travis tests were successfulHey @gitwouter, |
Signed-off-by: Wouter Denayer <[email protected]>
Travis tests were successfulHey @gitwouter, |
Signed-off-by: Wouter Denayer <[email protected]>
Signed-off-by: Wouter Denayer <[email protected]>
Travis tests were successfulHey @gitwouter, |
| return new String[] { key, value }; | ||
| }).collect(Collectors.toMap(x -> x[0], x -> x[1])); | ||
|
|
||
| if (responseMap.get("ret") != null && responseMap.get("ret").contentEquals("OK")) { |
There was a problem hiding this comment.
Swap parameters and null check can be omitted:
| if (responseMap.get("ret") != null && responseMap.get("ret").contentEquals("OK")) { | |
| if ("OK".equals(responseMap.get("ret"))) { |
| thisWeekEnergy += Integer.parseInt(heatingValues[i]); | ||
| } | ||
| double previousWeekEnergy = 0; | ||
| for (int i = thisWeekLastDayIndex; i < thisWeekLastDayIndex + 7; i += 1) { |
There was a problem hiding this comment.
| for (int i = thisWeekLastDayIndex; i < thisWeekLastDayIndex + 7; i += 1) { | |
| for (int i = thisWeekLastDayIndex; i < thisWeekLastDayIndex + 7; i++) { |
and same comment for other loops.
| @@ -184,6 +186,12 @@ protected void updateTemperatureChannel(String channel, Optional<Double> maybeTe | |||
| .orElse(UnDefType.UNDEF)); | |||
| } | |||
|
|
|||
| protected void updateEnergyChannel(String channel, Optional<Double> maybeEnergy) { | |||
| updateState(channel, | |||
| maybeEnergy.<State>map(t -> new QuantityType<>(new DecimalType(t), SmartHomeUnits.KILOWATT_HOUR)) | |||
There was a problem hiding this comment.
| maybeEnergy.<State>map(t -> new QuantityType<>(new DecimalType(t), SmartHomeUnits.KILOWATT_HOUR)) | |
| maybeEnergy.<State>map(t -> new QuantityType<>(t, SmartHomeUnits.KILOWATT_HOUR)) |
Hilbrand
added
the
enhancement
| // /aircon/get_week_power_ex | ||
| // ret=OK,s_dayw=0,week_heat=1/1/1/1/1/5/2/1/1/1/1/2/1/1,week_cool=0/0/0/0/0/0/0/0/0/0/0/0/0/0 | ||
| // week_heat=<today>/<today-1>/<today-2>/<today-3>/... | ||
| Map<String, String> responseMap = Arrays.asList(response.split(",")).stream().filter(kv -> kv.contains("=")) |
There was a problem hiding this comment.
You should use InfoParser.parse(response); The InfoParser class also has some new methods: parseArrayofInt that you could use to parse the specific values below. That might simplify the code too.
There was a problem hiding this comment.
I should remove this pull request. While I was in discussion/feedback on this PR another one was merged and made my work obsolete. Cf. https://community.openhab.org/t/daikin-binding-logging-energy-usage/96964
There was a problem hiding this comment.
I might be wrong, but if you're referring to #7708. It doesn't look like that pr overlapped with your pr. That pr added monthly reports, while you added daily/weekly data. That seems other data. So I think your changes are still relevant and from a quick look that pr added some methods that might could make your code simpler by using the added helper methods for parsing the data.
Adding support for energy usage reading to the binding
Reading the aircon/get_week_power_ex endpoint to get energy usage reading for heating & cooling for today, this week & last week.