Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mcp23017] Added hint to the wiringPi library #5000

Merged
merged 4 commits into from
Feb 26, 2019
Merged

Conversation

cweitkamp
Copy link
Contributor

Without this dependency the pi4j library did not work on my Raspberry Pi Model 3 B+.
Unfortunately there is another issue Pi4J/pi4j#319 which can be resolved by updating to pi4j release 1.2 (not yet released).

Supersedes #4806.

// CC @mrumpf

Also-by: Michael Rumpf [email protected] (github: mrumpf)
Signed-off-by: Christoph Weitkamp [email protected]

Without this dependency the pi4j library did not work on my Raspberry Pi Model 3 B+.
Unfortunately there is another issue Pi4J/pi4j#319 which can be resolved by updating to pi4j release 1.2 (not yet released).

Also-by: Michael Rumpf <[email protected]> (github: mrumpf)
Signed-off-by: Christoph Weitkamp <[email protected]>
@cweitkamp
Copy link
Contributor Author

@kaikreuzer Can you please add @aogorek to the team? Thanks.

Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also fix the link and some casing while you're at it? :-)

@cweitkamp
Copy link
Contributor Author

@wborn Why me? You did it 😉!

Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Yes now my suggestion is applied it's also by me. :-)

@wborn wborn merged commit 2f621a6 into openhab:master Feb 26, 2019
@wborn
Copy link
Member

wborn commented Feb 26, 2019

Unfortunately there is another issue Pi4J/pi4j#319 which can be resolved by updating to pi4j release 1.2

Seems the official 1.2 release is being worked on: Pi4J/pi4j#418 (comment)

@cweitkamp cweitkamp deleted the pr-4806 branch February 26, 2019 20:06
@kaikreuzer
Copy link
Member

@kaikreuzer Can you please add @aogorek to the team? Thanks.

Done.

@wborn wborn added this to the 2.5 milestone Feb 28, 2019
@wborn
Copy link
Member

wborn commented Feb 28, 2019

Pi4J version 1.2 has been released @cweitkamp! Maybe you can update the library in a new PR. :-)

@cweitkamp
Copy link
Contributor Author

Okay, I will do that.

@cweitkamp
Copy link
Contributor Author

Maybe you can update the library in a new PR.

Done.

Pshatsillo pushed a commit to Pshatsillo/openhab-addons that referenced this pull request Jun 19, 2019
Without this dependency the pi4j library did not work on my Raspberry Pi Model 3 B+.
Unfortunately there is another issue Pi4J/pi4j#319 which can be resolved by updating to pi4j release 1.2 (not yet released).

Also-by: Michael Rumpf <[email protected]> (github: mrumpf)
Also-by: Wouter Born <[email protected]>
Signed-off-by: Christoph Weitkamp <[email protected]>
Signed-off-by: Pshatsillo <[email protected]>
ne0h pushed a commit to ne0h/openhab-addons that referenced this pull request Sep 15, 2019
Without this dependency the pi4j library did not work on my Raspberry Pi Model 3 B+.
Unfortunately there is another issue Pi4J/pi4j#319 which can be resolved by updating to pi4j release 1.2 (not yet released).

Also-by: Michael Rumpf <[email protected]> (github: mrumpf)
Also-by: Wouter Born <[email protected]>
Signed-off-by: Christoph Weitkamp <[email protected]>
Signed-off-by: Maximilian Hess <[email protected]>
@wborn wborn removed this from the 2.5 milestone Dec 8, 2019
@wborn wborn added this to the 2.5 milestone Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants