[mcp23017] Added hint to the wiringPi library #4806
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this dependency the pi4j library did not work on my Raspberry Pi Model 3 B+. Unfortunately there is another issue Pi4J/pi4j#319 which can be resolved by updating to pi4j release 1.2 (not yet released)
wborn
changed the title
There was a problem hiding this comment.
Hey @mrumpf thanks for the improvement.
Looks good so far, just one small comment below.
@openhab/2-x-add-ons-maintainers can this get merged under small patch exception os is a sign-off mandatory?
|
|
||
| On Raspberry PI user on which openHAB is running (default user name is "openhab") needs to be added to groups "i2c" and "gpio". | ||
|
|
||
| ## Dependencies | ||
|
|
||
| Make sure that the [wiringPi](http://wiringpi.com/) library has been installed and that the `gpio` command line tool is available to OpenHAB. The shared library `libwiringPi.so` is required by the pi4j Java library to access the GPIO ports. Without satisfying this dependency you will see strange `NoClassDefFoundError: Could not initialize class ...` errors in the OpenHAB logs. |
There was a problem hiding this comment.
Please break down to one line per sentence.
cweitkamp
reviewed
Feb 5, 2019
|
|
||
| On Raspberry PI user on which openHAB is running (default user name is "openhab") needs to be added to groups "i2c" and "gpio". | ||
|
|
||
| ## Dependencies | ||
|
|
||
| Make sure that the [wiringPi](http://wiringpi.com/) library has been installed and that the `gpio` command line tool is available to OpenHAB. The shared library `libwiringPi.so` is required by the pi4j Java library to access the GPIO ports. Without satisfying this dependency you will see strange `NoClassDefFoundError: Could not initialize class ...` errors in the OpenHAB logs. |
There was a problem hiding this comment.
Fix spelling of openHAB. Please check the whole documentation.
davidgraeff
added
the
awaiting feedback
cweitkamp
removed
the
awaiting feedback
|
It looks like the original branch was removed and a pull request with the changes was created against the repository of the original pr and not this repository. I don't know if it works to create a branch with the original name in the repository this PR was created, otherwise a new PR should be created. |
|
Superseded by #5000 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this dependency the pi4j library did not work on my Raspberry Pi Model 3 B+.
Unfortunately there is another issue Pi4J/pi4j#319 which can be resolved by updating to pi4j release 1.2 (not yet released)