[evohome] Add UoM and semantic tags for temperature channels #13885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leo Siepel <[email protected]>
lsiepel
added
the
additional testing preferred
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/evohome-binding-2-0/37264/276 |
jlaur
requested changes
Dec 25, 2022
...binding.evohome/src/main/java/org/openhab/binding/evohome/internal/api/EvohomeApiClient.java
Show resolved
Hide resolved
...binding.evohome/src/main/java/org/openhab/binding/evohome/internal/api/EvohomeApiClient.java
Show resolved
Hide resolved
...binding.evohome/src/main/java/org/openhab/binding/evohome/internal/api/EvohomeApiClient.java
Show resolved
Hide resolved
...penhab.binding.evohome/src/main/java/org/openhab/binding/evohome/internal/api/ApiAccess.java
Outdated
Show resolved
Hide resolved
...penhab.binding.evohome/src/main/java/org/openhab/binding/evohome/internal/api/ApiAccess.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/openhab/binding/evohome/internal/handler/EvohomeAccountBridgeHandler.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/openhab/binding/evohome/internal/handler/EvohomeAccountBridgeHandler.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/openhab/binding/evohome/internal/handler/EvohomeAccountBridgeHandler.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/openhab/binding/evohome/internal/handler/EvohomeAccountBridgeHandler.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/openhab/binding/evohome/internal/handler/EvohomeAccountBridgeHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: lsiepel <[email protected]>
Signed-off-by: lsiepel <[email protected]>
Signed-off-by: lsiepel <[email protected]>
jlaur
reviewed
Dec 26, 2022
...penhab.binding.evohome/src/main/java/org/openhab/binding/evohome/internal/api/ApiAccess.java
Show resolved
Hide resolved
jlaur
reviewed
Dec 26, 2022
.../src/main/java/org/openhab/binding/evohome/internal/handler/EvohomeAccountBridgeHandler.java
Show resolved
Hide resolved
jlaur
reviewed
Dec 26, 2022
.../src/main/java/org/openhab/binding/evohome/internal/handler/EvohomeAccountBridgeHandler.java
Show resolved
Hide resolved
Signed-off-by: lsiepel <[email protected]>
Signed-off-by: lsiepel <[email protected]>
I think it would be good to have some actual tests as there are no tests to this bundle and null annotation refactoring have been the cause for many bugs :-) I'll also ask on the community forums, but without some enhancements not much users are willing to spend their time on it. |
jlaur
reviewed
Dec 26, 2022
.../src/main/java/org/openhab/binding/evohome/internal/handler/EvohomeAccountBridgeHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: lsiepel <[email protected]>
Signed-off-by: lsiepel <[email protected]>
Signed-off-by: lsiepel <[email protected]>
|
@jlaur Ready for merge as tests have been performed, all seems fine. |
jlaur
requested changes
Feb 24, 2023
.../src/main/java/org/openhab/binding/evohome/internal/handler/EvohomeAccountBridgeHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: lsiepel <[email protected]>
jlaur
removed
the
additional testing preferred
|
@lsiepel - you could change the PR title to be about the UoM channel additions, and we could add "enhancement" label to have this mentioned in the release notes. |
lsiepel
added
the
enhancement
lsiepel
changed the title
Updated it, feel free to adjust it to release note needs. |
jlaur
changed the title
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
Signed-off-by: Leo Siepel <[email protected]>
miloit
pushed a commit
to miloit/openhab-addons
that referenced
this pull request
Mar 10, 2023
Signed-off-by: Leo Siepel <[email protected]> Signed-off-by: miloit <[email protected]>
renescherer
pushed a commit
to renescherer/openhab-addons
that referenced
this pull request
Mar 23, 2023
Signed-off-by: Leo Siepel <[email protected]>
FordPrfkt
pushed a commit
to FordPrfkt/openhab-addons
that referenced
this pull request
Apr 20, 2023
Signed-off-by: Leo Siepel <[email protected]>
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Leo Siepel [email protected]
Left the warnings about unused private fields untouched as these are part of the DTO responses and might be used in the future.
The jar (3.4.1) is here: https://1drv.ms/u/s!AnMcxmvEeupwjp4MT2ZumTKtulvBWg?e=yrmAmM
(updated after last commit as of 2023-01-07 15:19)
I keep this here as draft while some tests are being performed. As i don't own such a device, we have to wait for others to complete the testing.