Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[evohome] Setpoint Send command 0 doesn't cancel the permanent override #9007

Closed
HellStorm666 opened this issue Nov 12, 2020 · 18 comments · Fixed by #13885
Closed

[evohome] Setpoint Send command 0 doesn't cancel the permanent override #9007

HellStorm666 opened this issue Nov 12, 2020 · 18 comments · Fixed by #13885
Assignees
@lsiepel
Labels
bug An unexpected problem or unintended behavior of an add-on

Comments

@HellStorm666
Copy link

HellStorm666 commented Nov 12, 2020 •
edited
Loading

since a few weeks I have a problem with the evohome binding.

Before, when I sended setpoint.sendCommand(0) to the evohome the permanent override got cancelled and thus evohome started to follow the schedule again.

However, if I now send this command, it tries to set the temp to 0, that fails and the temperature stays at a given temperature with permanent override.

I don't see any strange errors in the logs.

Also, sending a setpoint.sendCommand(10) does change the info in AopenHab, but doenst change it in the Evohome app, so my guess is that it doens't write to evohome.
If I change settings in evohome, it will display the changed values in Openhab2, so reading the data does work.
@HellStorm666 HellStorm666 added the bug An unexpected problem or unintended behavior of an add-on label Nov 12, 2020
@wborn wborn changed the title [Evohome] Setpoint Send command 0 doesn't cancel the permanent override [evohome] Setpoint Send command 0 doesn't cancel the permanent override Nov 22, 2020
@HellStorm666
Copy link
Author

Any update on this?

Looks like writing any value to the evohome does get changed in OpenHAB, but a few seconds after that it gets overwritten with the value in the Evohome app value.

So, as example, the set-temp in the evohome app (and display) is 17C.
Setting this to 10C in OpenHAB gives a 'set temp to 10C' and 'expected temp to become 10C'. And after a few seconds I get a temp is 17C.

So it looks like the value isn't send to evohome, or evohome ignores the value.

@Birchcroft
Copy link

I have the same problem on 1 of my heating zones. On careful inspection I found that I had set the "Set Point Item" to type "number:temperature" for that heating zone, whereas it was set to type "number" for the others. Changing it to type "number" appears to have resolved the problem, although I need to monitor it for a while to check.

@lsiepel
Copy link
Contributor

lsiepel commented Jan 7, 2023

I might look into this issue and come up with a fix. Are you available for performing some tests, run it for a couple of days?

@Birchcroft
Copy link

Birchcroft commented Jan 7, 2023 via email

@lsiepel
Copy link
Contributor

lsiepel commented Jan 7, 2023

It is because Units of measure is not supported by the binding. I created a new version as i was allready doing some refactoring.
3.4.1. Test version: https://1drv.ms/u/s!AnMcxmvEeupwjp4MT2ZumTKtulvBWg?e=yrmAmM Anyone testing this, please report back so we can get this merged.

  • Added UoM.
  • Added null annotations
  • Added default semantic tags

If you have textual config just update your Item config from to Number:Temperature (for both SetPoint and Temperature)
channel. Of recreate the Thing from the UI.

@lsiepel lsiepel mentioned this issue Jan 7, 2023
Merged
@openhab-bot
Copy link
Collaborator

This issue has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/evohome-binding-2-0/37264/277

@lsiepel
Copy link
Contributor

lsiepel commented Jan 24, 2023

@HellStorm666 gentle ping as you raised this issue, are you able to perform some tests ?

@lsiepel
Copy link
Contributor

lsiepel commented Feb 5, 2023

@Birchcroft Are you able to do some basic tests?

@lsiepel lsiepel self-assigned this Feb 5, 2023
@Birchcroft
Copy link

@lsiepel I don't have a great deal of time but if you send me instructions on how to download and install what you want tested I will try and fit it in over the next week or so.

@lsiepel
Copy link
Contributor

lsiepel commented Feb 6, 2023

  1. Uninstall the current evohome binding
  2. Download the 3.4.x jar here: https://1drv.ms/u/s!AnMcxmvEeupwjqVYEk7vWMf-I5fFNQ?e=Q1ands
  3. Place the jar in the addons folder.
  4. Update both temperature channels (ui or textual might differ, as long as you change them form Number to Number: Temperature it will be fine. )
  5. Perform soms tests (init the things, perform commands and watch some values get updated)

If you encounter some issues, let me know the details: what channel / values / error from log etc. Thanks a lot for testing!

@Birchcroft
Copy link

Birchcroft commented Feb 7, 2023 via email

@Birchcroft
Copy link

Birchcroft commented Feb 8, 2023 via email

@lsiepel
Copy link
Contributor

lsiepel commented Feb 9, 2023

Don't know why there are these intermediate states, not something that i would suspect from the code change. Could you share the log of evohome, preferrably in debug mode? If i have that log i can determine the cause/origin from the changes.
From console:
log:set debug org.openhab.binding.evohome

Thanks for spending some time on this!

@Birchcroft
Copy link

Will do when I get chance

@lsiepel
Copy link
Contributor

lsiepel commented Feb 10, 2023

No need to rush, take your time.

@Birchcroft
Copy link

Birchcroft commented Feb 22, 2023 via email

@lsiepel
Copy link
Contributor

lsiepel commented Feb 22, 2023 •
edited
Loading

That 201 is certainly unexpected for the request performed, but I guess that is what evohome api returns. Will look at the code for a fix. But this is not introduced by this change. Edit: change change only logged it. have made an additional commit that fixes this logging. No functional change.

thanks for testing, great that all seems fine.

@openhab-bot
Copy link
Collaborator

This issue has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/evohome-binding-on-oh4-0-1-not-working/148548/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lsiepel lsiepel

Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[evohome] Add UoM and semantic tags for temperature channels lsiepel/openhab-addons
4 participants
@HellStorm666 @openhab-bot @lsiepel @Birchcroft