[influxdb] Fix queries with InfluxDB 2.0 with data migrated from InfluxDB1 without item tags #10937
+27
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joan Pujol <[email protected]>
fwolter
approved these changes
Jul 6, 2021
computergeek1507
pushed a commit
to computergeek1507/openhab-addons
that referenced
this pull request
Jul 13, 2021
… tags (openhab#10937) Signed-off-by: Joan Pujol <[email protected]>
frederictobiasc
pushed a commit
to frederictobiasc/openhab-addons
that referenced
this pull request
Oct 26, 2021
… tags (openhab#10937) Signed-off-by: Joan Pujol <[email protected]>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
… tags (openhab#10937) Signed-off-by: Joan Pujol <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
… tags (openhab#10937) Signed-off-by: Joan Pujol <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug in queries with InfluxDB 2.0 that had data migrated from InfluxDB 1.0 with old versions of the addon that didn't put item tag name.
In that case, the result contained several group keys and could give bad results, for example in sort queries like
deltaSincethat failed because sort was applied per series and not for all the results.Completes work done on #10888 to cover all casuistic.
There isn't any open issue but the problem was commented on in that thread
https://community.openhab.org/t/influx-db2-openhab-3-1m5-deltasince-start-of-day-not-working-when-lines-without-item-name-in-database-from-openhab-2-5/123546/26