Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[influxdb] v2: Fix history queries if items are not tagged #10888

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

t2000
Copy link
Contributor

@t2000 t2000 commented Jun 20, 2021

Was missing in #10680

Fixes #10887

Signed-off-by: Stefan Triller [email protected]

@t2000 t2000 requested a review from lujop as a code owner June 20, 2021 14:58
@lujop
Copy link
Contributor

lujop commented Jun 20, 2021

Thanks @t2000
Looks good for me.
But can you attach the build addon in the PR to let Asmodeon verify it

(from https://community.openhab.org/t/influx-db2-openhab-3-1m5-deltasince-start-of-day-not-working-when-lines-without-item-name-in-database-from-openhab-2-5/123546/8)

@t2000
Copy link
Contributor Author

t2000 commented Jun 20, 2021

org.openhab.persistence.influxdb-3.1.0-SNAPSHOT.zip

This is the jar (please rename) I copied from my developer eclipse installation. Should be sufficient I hope. Otherwise, please ping me.

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/influx-db2-openhab-3-1m5-deltasince-start-of-day-not-working-when-lines-without-item-name-in-database-from-openhab-2-5/123546/13

Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@kaikreuzer kaikreuzer merged commit 7c221d0 into openhab:main Jun 21, 2021
@kaikreuzer kaikreuzer added this to the 3.1 milestone Jun 21, 2021
@kaikreuzer kaikreuzer added the bug An unexpected problem or unintended behavior of an add-on label Jun 21, 2021
@t2000 t2000 deleted the fixInflux2HistoricData branch June 21, 2021 14:38
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Jul 26, 2021
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Jul 26, 2021
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Aug 3, 2021
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InfluxDB v2 historic data are broken
4 participants