Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a connection with secret type 'kubernetes.io/dockerconfigjson' #3760

Conversation

emilys314
Copy link
Contributor

https://issues.redhat.com/browse/RHOAIENG-19053

Description

When creating a connection, checks if there is stuff in the .dockerconfigfile, and instead of an "Opaque" secret it will be "kubeneties.io/dockerconfigjson"

Screenshot From 2025-02-12 16-31-04

Screenshot From 2025-02-12 16-37-18

How Has This Been Tested?

  • Create / edit connection type
  • add a new field named .dockerconfigjson and save
  • go to project and create a connection
  • upload a file for the .dockerconfigjson field and submit
  • check the created secret in openshift console has type "kubeneties.io/dockerconfigjson"

Test Impact

Cypress test added for flow

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.38%. Comparing base (bc2413e) to head (dbde6af).
Report is 12 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3760      +/-   ##
==========================================
+ Coverage   84.28%   84.38%   +0.10%     
==========================================
  Files        1470     1486      +16     
  Lines       33838    34052     +214     
  Branches     9385     9439      +54     
==========================================
+ Hits        28520    28736     +216     
+ Misses       5318     5316       -2     
Files with missing lines Coverage Δ
frontend/src/concepts/connectionTypes/utils.ts 93.30% <100.00%> (+0.06%) ⬆️

... and 36 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc2413e...dbde6af. Read the comment docs.

Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Tested on my cluster after rebasing on #3759 and it works like a charm

@emilys314
Copy link
Contributor Author

/approve

Copy link
Contributor

openshift-ci bot commented Feb 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: emilys314, Griffin-Sullivan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 0b67b3e into opendatahub-io:main Feb 14, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants