Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less strict connection field env variable names #3759

Conversation

emilys314
Copy link
Contributor

https://issues.redhat.com/browse/RHOAIENG-19860

Description

This allows setting the env var of connection type fields to match this https://kubernetes.io/docs/concepts/configuration/secret/#restriction-names-data so this will allow us to use .dockerconfigjson as an env var in connections

image

image

image

How Has This Been Tested?

  1. Create / edit connection type
  2. add a new field named .dockerconfigjson and save
  3. go to project and create a connection with that field

Test Impact

Update jest validation tests

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

@simrandhaliw

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.28%. Comparing base (bc2413e) to head (6ba9b2c).
Report is 11 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3759   +/-   ##
=======================================
  Coverage   84.28%   84.28%           
=======================================
  Files        1470     1470           
  Lines       33838    33838           
  Branches     9385     9385           
=======================================
  Hits        28520    28520           
  Misses       5318     5318           
Files with missing lines Coverage Δ
...c/concepts/connectionTypes/fields/UriFormField.tsx 100.00% <100.00%> (ø)
frontend/src/concepts/connectionTypes/utils.ts 93.23% <100.00%> (ø)
...nd/src/concepts/connectionTypes/validationUtils.ts 100.00% <ø> (ø)
...ctionTypes/manage/ConnectionTypeDataFieldModal.tsx 85.48% <100.00%> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc2413e...6ba9b2c. Read the comment docs.

@ashley-o0o
Copy link
Contributor

Tested on my cluster. I'm now able to use the name .dockerconfigjson for my environment variable. Update works as described in the Kubernetes guide.
/lgtm
Screenshot 2025-02-14 at 1 39 25 PM
Screenshot 2025-02-14 at 1 49 57 PM

@emilys314
Copy link
Contributor Author

/approve

Copy link
Contributor

openshift-ci bot commented Feb 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: emilys314

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 96d8eb8 into opendatahub-io:main Feb 14, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants