Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.2] CI: fix criu-dev compile #4611

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented Feb 1, 2025

As of 1, criu requires uuid library.

Cherry picked from commit bccaab8 / PR #4609. Draft until that one is merged.

@kolyshkin kolyshkin added area/ci backport/1.2-pr A backport PR to release-1.2 labels Feb 1, 2025
@kolyshkin kolyshkin modified the milestones: 1.2.4, 1.2.5 Feb 1, 2025
Copy link
Member

@rata rata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Reviewing as it is not draft and I already review the PR to main :)

As of [1], criu requires uuid library.

[1]: checkpoint-restore/criu@9a2b7d6

Signed-off-by: Kir Kolyshkin <[email protected]>
(cherry picked from commit f414b53)
Signed-off-by: Kir Kolyshkin <[email protected]>
@kolyshkin
Copy link
Contributor Author

Ah, I forgot to convert it to draft earlier. Anyway, #4609 is merged. I've updated this one (the only change is commit sha in main).

Copy link
Member

@cyphar cyphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyphar cyphar merged commit 456d770 into opencontainers:release-1.2 Feb 5, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci backport/1.2-pr A backport PR to release-1.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants