Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.2] deps: update to github.com/cyphar/[email protected] #4608

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

kolyshkin
Copy link
Contributor

This release includes a minor breaking API change that requires us to rework the types of our wrappers, but there is no practical behaviour change.

(cherry picked from commit 70e500e / PR #4590)

The reason for backport is anyone who vendors runc couldn't bump filepath-securejoin otherwise.

@kolyshkin kolyshkin added the backport/1.2-pr A backport PR to release-1.2 label Jan 31, 2025
@kolyshkin kolyshkin added this to the 1.2.5 milestone Jan 31, 2025
@kolyshkin kolyshkin requested review from cyphar and rata and removed request for cyphar January 31, 2025 22:09
@kolyshkin kolyshkin marked this pull request as ready for review January 31, 2025 22:09
Copy link
Member

@cyphar cyphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@rata rata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rata
Copy link
Member

rata commented Feb 5, 2025

Tests are failing because #4611 is not yet merged. I'd say let's wait for that to be merged, rebase and verify tests pass fine before merging. Although it is highly likely all will work fine, it's not too much work to verify :)

This release includes a minor breaking API change that requires us to
rework the types of our wrappers, but there is no practical behaviour
change.

Signed-off-by: Aleksa Sarai <[email protected]>
(cherry picked from commit 70e500e)
Signed-off-by: Kir Kolyshkin <[email protected]>
@rata
Copy link
Member

rata commented Feb 5, 2025

Tests are green, thanks @cyphar !

@rata rata merged commit de92f4b into opencontainers:release-1.2 Feb 5, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.2-pr A backport PR to release-1.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants