-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a background to build states which are still in flux #8170
Add a background to build states which are still in flux #8170
Conversation
the succeeded in black looks strange ( |
@coolo upps, just ignore it, I manually changed the class on the html element in the browser to get all the states into one screenshot ;) |
He might actually be born in that future :) |
color: $dark; | ||
@extend .text-white; | ||
@extend .px-1; | ||
background-color: $dark; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be some shade of yellow. Both are intermediate steps between building and the final result (green/red). You can not really do much about this state, it shouldn't be as heavy as disabled/blocked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hennevogel done
Codecov Report
@@ Coverage Diff @@
## master #8170 +/- ##
==========================================
+ Coverage 90.82% 90.83% +<.01%
==========================================
Files 502 502
Lines 21445 21445
==========================================
+ Hits 19477 19479 +2
+ Misses 1968 1966 -2 |
The old webui used to set a background to states which suppose to change.
109c73c
to
873e93b
Compare
The old webui used to set a background to states which suppose to change.
** Old Webui**

** Same with colors in our new Webui**
