Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a background to build states which are still in flux #8170

Merged
merged 1 commit into from
Aug 26, 2019

Conversation

krauselukas
Copy link
Contributor

@krauselukas krauselukas commented Aug 23, 2019

The old webui used to set a background to states which suppose to change.

** Old Webui**
Screenshot-2019-8-23 openSUSE Build Service(2)

** Same with colors in our new Webui**
Screenshot-2019-8-23 Open Build Service(1)

@coolo
Copy link
Member

coolo commented Aug 23, 2019

the succeeded in black looks strange (termrec)

@krauselukas krauselukas added the Frontend Things related to the OBS RoR app label Aug 23, 2019
@krauselukas
Copy link
Contributor Author

krauselukas commented Aug 23, 2019

the succeeded in black looks strange (termrec)

@coolo upps, just ignore it, I manually changed the class on the html element in the browser to get all the states into one screenshot ;)
I updated the screenshot

@hennevogel
Copy link
Member

hennevogel commented Aug 23, 2019

You have missed the unparalleled opportunity to make flux capacitor jokes! Lukas!

Should Eyes from Light

@coolo
Copy link
Member

coolo commented Aug 23, 2019

He might actually be born in that future :)

color: $dark;
@extend .text-white;
@extend .px-1;
background-color: $dark;
Copy link
Member

@hennevogel hennevogel Aug 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be some shade of yellow. Both are intermediate steps between building and the final result (green/red). You can not really do much about this state, it shouldn't be as heavy as disabled/blocked.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented Aug 24, 2019

Codecov Report

Merging #8170 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8170      +/-   ##
==========================================
+ Coverage   90.82%   90.83%   +<.01%     
==========================================
  Files         502      502              
  Lines       21445    21445              
==========================================
+ Hits        19477    19479       +2     
+ Misses       1968     1966       -2

The old webui used to set a background to states which
suppose to change.
@hennevogel hennevogel merged commit 1b09312 into openSUSE:master Aug 26, 2019
@krauselukas krauselukas deleted the background_buildstatus branch September 26, 2019 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Things related to the OBS RoR app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants