Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor page: apply style to build status legend #8187

Open
eduardoj opened this issue Aug 27, 2019 · 3 comments
Open

Monitor page: apply style to build status legend #8187

eduardoj opened this issue Aug 27, 2019 · 3 comments
Labels
Design Issues about the design of a page Feature Frontend Things related to the OBS RoR app good first issue Easy task, perfect for a first contribution

Comments

@eduardoj
Copy link
Member

Is your feature request related to a problem? Please describe.
Some style changes were applied on build status in the monitor page. It would be nice to apply the same styles in the legend.

Describe the solution you'd like
Use the same styles in the legend than in the table, for describing each build status.

Describe alternatives you've considered
None.

Additional context
One of the last pull request regarding these style changes: #8170.

@eduardoj eduardoj added Frontend Things related to the OBS RoR app Design Issues about the design of a page labels Aug 27, 2019
@darix
Copy link
Member

darix commented Aug 27, 2019

👍

@hennevogel
Copy link
Member

LGTM
Screenshot from 2023-05-09 17-04-31

@eduardoj
Copy link
Member Author

eduardoj commented May 9, 2023

Making things more clear, by providing an example:

  • the string "succeeded" shows itself with a green font in the monitor page
  • the purpose of the issue is showing the "succeded" string with a green font in the build status legend.

And the same for the rest of the elements of the legend.

@eduardoj eduardoj reopened this May 9, 2023
@hennevogel hennevogel added the good first issue Easy task, perfect for a first contribution label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Issues about the design of a page Feature Frontend Things related to the OBS RoR app good first issue Easy task, perfect for a first contribution
Projects
None yet
Development

No branches or pull requests

4 participants