Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the end timestamp and mutable span as requirements in onending #4240

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Make the end timestamp and mutable span as requirements in onending #4240

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d610320
make the end timestamp and mutable span as requirements in onending
dmathieu Oct 3, 2024
8eff68f
clarify that it's only computation of the timestamp that needs to hap…
dmathieu Oct 3, 2024
b173928
Update specification/trace/sdk.md
dmathieu Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion specification/trace/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,7 +607,10 @@ are invoked in the order they have been registered.

**Status**: [Development](../document-status.md)

`OnEnding` is called during the span `End()` operation, after the end timestamp has been set. The Span object is still mutable (i.e., `SetAttribute`, `AddLink`, `AddEvent` can be called) while `OnEnding` is called.
`OnEnding` is called during the span `End()` operation.
The end timestamp MUST have been computed (the `OnEnding` method duration is not included
in the span duration).
The Span object MUST still be mutable (i.e., `SetAttribute`, `AddLink`, `AddEvent` can be called) while `OnEnding` is called.
This method MUST be called synchronously within the [`Span.End()` API](api.md#end),
therefore it should not block or throw an exception.
If multiple `SpanProcessors` are registered, their `OnEnding` callbacks
Expand Down
Loading