Make the end timestamp and mutable span as requirements in onending #4240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellared
approved these changes
Oct 3, 2024
pellared
added
spec:trace
yurishkuro
approved these changes
Oct 3, 2024
cijothomas
reviewed
Oct 3, 2024
cijothomas
approved these changes
Oct 3, 2024
lmolkova
approved these changes
Oct 3, 2024
|
There is no way to query the end timestamp on the span. Does it matter if it is set or not? |
|
It does, because if the callback duration will affect the timestamp value if we set it afterwards. |
|
I see. Should it be clarified that the end time should exclude the time it takes to run the processors? It seems like requiring it being set is more restrictive than it needs to be. |
|
That makes sense. I've made the change. |
cijothomas
reviewed
Oct 3, 2024
Co-authored-by: Cijo Thomas <[email protected]>
carlosalberto
approved these changes
Oct 8, 2024
reyang
approved these changes
Oct 8, 2024
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
OnEndingspecifies that the ending timestamp should be set when the callback runs, and the span should be mutable.These are requirements, so it seems like they should be marked as so.