Makefile: add api-docs to bundle rule #2544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frzifus
force-pushed
the
fix_api_doc_verification
branch
2 times, most recently
from
5764d48 to
a5162bd
Compare
pavolloffay
reviewed
Jan 19, 2024
Makefile
Outdated
| @@ -192,7 +192,7 @@ lint: golangci-lint | |||
|
|
|||
| # Generate code | |||
| .PHONY: generate | |||
| generate: controller-gen | |||
| generate: api-docs controller-gen | |||
There was a problem hiding this comment.
the api-docs traget was remvoed from generate to improve developer UX by minimizing local changes when developing the operator. #2421
There was a problem hiding this comment.
Was that actually necessary? api-docs is a noop if you haven't made any changes impacting the docs, so it should be fine to have it here.
There was a problem hiding this comment.
What does the generate update? Is it the deepcopy?
I think the api-docs generate should be bundled with the target to generate CRD
There was a problem hiding this comment.
generate only generates the deepcopy code, yes.
There was a problem hiding this comment.
But I do agree that api-docs should be a part of bundle rather than generate.
Signed-off-by: Benedikt Bongartz <[email protected]>
frzifus
force-pushed
the
fix_api_doc_verification
branch
from
a5162bd to
6612838
Compare
swiatekm
approved these changes
Jan 20, 2024
jaronoff97
changed the title
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
Signed-off-by: Benedikt Bongartz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Link to tracking Issue:
Testing:
Documentation: