Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve developer experience by minimizing local changes #2421

Merged
merged 4 commits into from
Dec 7, 2023
Merged

Improve developer experience by minimizing local changes #2421

merged 4 commits into from
Dec 7, 2023

Conversation

pavolloffay
Copy link
Member

Description:

Replaces #1794

Link to tracking Issue:

Testing:

Documentation:

@pavolloffay
Improve developer experience
0cbdd29 
Signed-off-by: Pavol Loffay <[email protected]>
@pavolloffay pavolloffay requested a review from a team December 6, 2023 12:51
@pavolloffay pavolloffay mentioned this pull request Dec 6, 2023
Closed
@pavolloffay pavolloffay added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 6, 2023
@pavolloffay
Fix
5966702 
Signed-off-by: Pavol Loffay <[email protected]>
@pavolloffay
handle e2e tests
b69c6a0 
Signed-off-by: Pavol Loffay <[email protected]>
swiatekm
swiatekm reviewed Dec 7, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
@pavolloffay
Fix
5bf2e9e 
Signed-off-by: Pavol Loffay <[email protected]>
@swiatekm swiatekm self-requested a review December 7, 2023 15:16
swiatekm
swiatekm approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an improvement for bundle updates, but I'd really like to get rid of the hack script altogether. I consider the fix for e2e tests temporary until we can figure out something better.

@pavolloffay pavolloffay merged commit 5566a01 into open-telemetry:main Dec 7, 2023
26 checks passed
@jaronoff97 jaronoff97 mentioned this pull request Jan 12, 2024
Closed
@pavolloffay pavolloffay mentioned this pull request Jan 19, 2024
Merged
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
@pavolloffay
Improve developer experience by minimizing local changes (open-teleme…
bab56a3 
…try#2421)

* Improve developer experience

Signed-off-by: Pavol Loffay <[email protected]>

* Fix

Signed-off-by: Pavol Loffay <[email protected]>

* handle e2e tests

Signed-off-by: Pavol Loffay <[email protected]>

* Fix

Signed-off-by: Pavol Loffay <[email protected]>

---------

Signed-off-by: Pavol Loffay <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swiatekm swiatekm swiatekm approved these changes

@iblancasa iblancasa iblancasa approved these changes

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavolloffay @iblancasa @swiatekm