Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: clean up dependencies #5484

Merged
merged 2 commits into from
Feb 19, 2025
+3 −74
Merged

deps: clean up dependencies #5484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18e8012
deps: clean up dependencies
pichlermarc Feb 18, 2025
2909e22
Merge branch 'main' into chore/deps-cleanup
pichlermarc Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions experimental/packages/sampler-jaeger-remote/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
"@opentelemetry/api": "^1.3.0"
},
"devDependencies": {
"@opentelemetry/api": "1.9.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I would have figured that the peerDep would suffice here. From npm help json section on peerDependencies:

       In npm versions 3 through 6, peerDependencies were not automatically
       installed, and would raise a warning if an invalid version of the peer
       dependency was found in the tree. As of npm v7, peerDependencies are
       installed by default.

npm@7 was the default npm version as of Node.js v15.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured that too, and in normal operation this is not an issue. There was, however, some problem when I tried to simulate a release locally. It ended up having a package conflict without that dependency for some reason.

"@types/mocha": "10.0.10",
"@types/node": "18.6.5",
"@types/sinon": "17.0.3",
Expand Down
75 changes: 2 additions & 73 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion packages/opentelemetry-resources/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@
},
"devDependencies": {
"@opentelemetry/api": ">=1.0.0 <1.10.0",
"@opentelemetry/resources_1.9.0": "npm:@opentelemetry/[email protected]",
"@types/mocha": "10.0.10",
"@types/node": "18.6.5",
"@types/sinon": "17.0.3",
Expand Down
Loading