deps: clean up dependencies #5484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5484 +/- ##
=======================================
Coverage 94.97% 94.97%
=======================================
Files 309 309
Lines 8017 8017
Branches 1706 1706
=======================================
Hits 7614 7614
Misses 403 403 |
trentm
approved these changes
Feb 18, 2025
| @@ -48,6 +48,7 @@ | |||
| "@opentelemetry/api": "^1.3.0" | |||
| }, | |||
| "devDependencies": { | |||
| "@opentelemetry/api": "1.9.0", | |||
There was a problem hiding this comment.
I guess I would have figured that the peerDep would suffice here. From npm help json section on peerDependencies:
In npm versions 3 through 6, peerDependencies were not automatically
installed, and would raise a warning if an invalid version of the peer
dependency was found in the tree. As of npm v7, peerDependencies are
installed by default.
npm@7 was the default npm version as of Node.js v15.
There was a problem hiding this comment.
I figured that too, and in normal operation this is not an issue. There was, however, some problem when I tried to simulate a release locally. It ended up having a package conflict without that dependency for some reason.
Merged
via the queue into
open-telemetry:main
with commit Feb 19, 2025
492ed35
18 of 19 checks passed
trentm
pushed a commit
to trentm/opentelemetry-js
that referenced
this pull request
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
@opentelemetry/apiwas missing in@opentelemetry/sampler-jaeger-remote@opentelemetry/[email protected]was still thereType of change
How Has This Been Tested?