-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: set explicit naming convention #262
chore: set explicit naming convention #262
Conversation
4ec40de
to
cffa4f9
Compare
closes open-telemetry#165 Signed-off-by: Olivier Albertini <[email protected]>
cffa4f9
to
f887675
Compare
Codecov Report
@@ Coverage Diff @@
## master #262 +/- ##
==========================================
+ Coverage 98.87% 98.88% +0.01%
==========================================
Files 67 67
Lines 2569 2597 +28
Branches 172 171 -1
==========================================
+ Hits 2540 2568 +28
Misses 29 29
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending comment about making separate parameter and private properties in constructors. Really glad to see more lint checks being added!!
Which problem is this PR solving?
Short description of the changes
Closes #165
Signed-off-by: Olivier Albertini [email protected]