Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set explicit naming convention #262

Merged

Conversation

OlivierAlbertini
Copy link
Member

Which problem is this PR solving?

  • Make easier review and set explicit naming conventions (that we can improve over time)

Short description of the changes

  • Require leading underscore for private members and protected properties
  • Require upper case for enum members

Closes #165
Signed-off-by: Olivier Albertini [email protected]

@OlivierAlbertini OlivierAlbertini force-pushed the feature/naming-convention branch from cffa4f9 to f887675 Compare September 14, 2019 20:33
@codecov-io
Copy link

codecov-io commented Sep 14, 2019

Codecov Report

Merging #262 into master will increase coverage by 0.01%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
+ Coverage   98.87%   98.88%   +0.01%     
==========================================
  Files          67       67              
  Lines        2569     2597      +28     
  Branches      172      171       -1     
==========================================
+ Hits         2540     2568      +28     
  Misses         29       29
Impacted Files Coverage Δ
.../opentelemetry-exporter-jaeger/test/jaeger.test.ts 100% <100%> (ø) ⬆️
...ic-tracer/test/export/InMemorySpanExporter.test.ts 100% <100%> (ø) ⬆️
...ry-basic-tracer/src/export/InMemorySpanExporter.ts 100% <100%> (ø) ⬆️
...ntelemetry-basic-tracer/src/export/ExportResult.ts 100% <100%> (ø) ⬆️
...ges/opentelemetry-core/src/trace/TracerDelegate.ts 100% <100%> (ø) ⬆️
...ckages/opentelemetry-exporter-jaeger/src/jaeger.ts 92% <50%> (ø) ⬆️
...pentelemetry-basic-tracer/src/NoopSpanProcessor.ts 75% <0%> (-25%) ⬇️
...kages/opentelemetry-basic-tracer/test/Span.test.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-basic-tracer/src/config.ts 100% <0%> (ø) ⬆️
... and 8 more

Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@draffensperger draffensperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending comment about making separate parameter and private properties in constructors. Really glad to see more lint checks being added!!

@mayurkale22 mayurkale22 merged commit a774d78 into open-telemetry:master Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set explicit rules about naming convention
4 participants